Numeric value to nginx.ingress.kubernetes.io/limit-rps does not work

[jpalomaki]

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

NGINX Ingress controller version: 0.9.0-beta.19

Kubernetes version (use kubectl version): 1.8.4-gke.0

Environment:

• Cloud provider or hardware configuration: GKE

What happened:
Rate limiting is not enforced when using numeric value to ingress annotation nginx.ingress.kubernetes.io/limit-rps

What you expected to happen:
Rate limiting ought to work with numeric values for said annotation (per documentation).

How to reproduce it (as minimally and precisely as possible):
Apply the said annotation to an ingress:
nginx.ingress.kubernetes.io/limit-rps: 5
Test using e.g. siege: siege -c 20 https://myexample.com

[pieterlange]

Can you dump your generated nginx config? eg kubectl exec <ingress pod> -- cat /etc/nginx/nginx.conf

[aledbf]

@jpalomaki all the values are strings. I will add a comment about this. If the value is a number it must be quoted

[jpalomaki]

👍