Merge pull request #4700 from TronWallet/fix/nodeport_externalips

adds hability to use externalIP when controller service is of type NodePort
kubernetes · Nov 26, 2019 · 95edf02 · 95edf02
2 parents 9f72cb3 + b14a694
commit 95edf02
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/internal/ingress/status/status.go b/internal/ingress/status/status.go
@@ -338,7 +338,13 @@ func statusAddressFromService(service string, kubeClient clientset.Interface) ([
 	case apiv1.ServiceTypeClusterIP:
 		return []string{svc.Spec.ClusterIP}, nil
 	case apiv1.ServiceTypeNodePort:
-		return []string{svc.Spec.ClusterIP}, nil
+		addresses := []string{}
+		if svc.Spec.ExternalIPs != nil {
+			addresses = append(addresses, svc.Spec.ExternalIPs...)
+		} else {
+			addresses = append(addresses, svc.Spec.ClusterIP)
+		}
+		return addresses, nil
 	case apiv1.ServiceTypeLoadBalancer:
 		addresses := []string{}
 		for _, ip := range svc.Status.LoadBalancer.Ingress {