Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate echoserver and add new container image based on cmd/echo #427

Closed
dims opened this issue Aug 8, 2018 · 9 comments
Closed

Deprecate echoserver and add new container image based on cmd/echo #427

dims opened this issue Aug 8, 2018 · 9 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@dims
Copy link
Member

dims commented Aug 8, 2018

please see discussion in kubernetes/kubernetes#67035

@dims
Copy link
Member Author

dims commented Aug 8, 2018

cc @aledbf

@rramkumar1
Copy link
Contributor

@dims Can you clarify the action items here? Is this still relevant?

@dims
Copy link
Member Author

dims commented Oct 25, 2018

@rramkumar1 it was prompted by @aledbf 's comment here - kubernetes/kubernetes#67035 (comment) - i don't know much beyond that. I think the idea was to drop nginx and write a pure go server that did the exact same thing

@aledbf
Copy link
Member

aledbf commented Oct 25, 2018

I think the idea was to drop nginx and write a pure go server that did the exact same thing

Exactly that 👍

@rramkumar1
Copy link
Contributor

@aledbf Does it make sense though to manage an echoserver binary for all of k8s in this repo?

I don't mind moving the binary in cmd/echo to a more centralized location (perhaps k/k?)

@rramkumar1
Copy link
Contributor

ping @aledbf

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 28, 2019
@rramkumar1
Copy link
Contributor

ping @dims and @aledbf

@rramkumar1 rramkumar1 added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 21, 2019
@rramkumar1
Copy link
Contributor

Closing due to inactivity. Please reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

5 participants