Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLBC] Changing front-end configuration does not remove unnecessary target proxies/ssl-certs #32

Closed
bowei opened this issue Oct 11, 2017 · 13 comments · Fixed by #894
Closed
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@bowei
Copy link
Member

bowei commented Oct 11, 2017

From @tonglil on March 20, 2017 17:59

Porting this issue from contrib over: kubernetes-retired/contrib#1517.

There is no enforcement of the annotation kubernetes.io/ingress.allow-http: "false" when it is set to false, after previously being set to true or unset.

See during the edge hop:

No deletion/cleanup enforcement happens if it is set to false.

Copied from original issue: kubernetes/ingress-nginx#468

@bowei
Copy link
Member Author

bowei commented Oct 11, 2017

From @nicksardo on April 21, 2017 19:7

No deletion/cleanup happens when removing the TLS section or pre-shared cert annotation. Will rename this to be more general.

@bowei
Copy link
Member Author

bowei commented Oct 11, 2017

From @nicksardo on April 24, 2017 18:41

Furthermore, if you disable TLS on an active ingress, then delete the ingress resource, the controller will fail to destroy resources. It doesn't try deleting the https forwarding rule or https target proxy, which means the URL map is still used.

@bowei
Copy link
Member Author

bowei commented Oct 11, 2017

From @montanaflynn on August 7, 2017 23:3

Any updates on this? We have a production ingress and are looking for a workaround.

@bowei
Copy link
Member Author

bowei commented Oct 11, 2017

From @nicksardo on August 7, 2017 23:19

@montanaflynn There's no fix yet.

You should be able to delete the HTTP forwarding rule and target proxy manually in the GCP Console. Highly recommend duplicating the issue in a test cluster and trying it out first.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2018
@bluecmd
Copy link

bluecmd commented Jan 16, 2018

It is still relevant, I just hit this today. /remove-lifecycle stale

@MichielDeMey
Copy link

Same issue here, changed to HTTPS only and the HTTP frontend was not deleted.
I deleted the HTTP frontend manually from the LB and that did not seem to have any side-effects on the traffic.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 5, 2018
@bowei bowei self-assigned this Feb 5, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 6, 2018
@metral
Copy link

metral commented May 23, 2018

Hitting this on v1.1.1

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 23, 2018
@nicksardo nicksardo added the kind/bug Categorizes issue or PR as related to a bug. label Jul 16, 2018
@nitrag
Copy link

nitrag commented Sep 3, 2018

Bump. Had to delete ingress, remove compute forwarding rule, wait, apply ingress. kubectl replace of ingress did not work.

@bowei
Copy link
Member Author

bowei commented Sep 3, 2018

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Sep 3, 2018
@raelga
Copy link
Member

raelga commented Mar 6, 2019

Still happening, added kubernetes.io/ingress.allow-http: "false" and the HTTP Frontend was not deleted.

Cleaned manually after adding the annotation by updating the Ingress Load Balancer removing the HTTP Frontend. Eventually, the HTTP Target Proxy was deleted by GCP.

@stephen-dexda
Copy link

Until this reaches production please document the manual cleanup required (or link to this bug) at https://cloud.google.com/kubernetes-engine/docs/concepts/ingress#disabling_http.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

Successfully merging a pull request may close this issue.