Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider Emitting Events for GC errors #143

Closed
freehan opened this issue Mar 7, 2018 · 6 comments
Closed

Consider Emitting Events for GC errors #143

freehan opened this issue Mar 7, 2018 · 6 comments
Assignees
@rramkumar1
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@freehan
Copy link
Contributor

freehan commented Mar 7, 2018

GC should record event when error occurs. Some GC problem needs user attention to fix. For instance, if user reference resources created by ingress controller from other manual configured resources. These resources could not be GCed. ingress controller will end up GC it forever and logging on the master while user gets zero signal to about the problem.
@nicksardo
Copy link
Contributor

Question is where to emit events for GC since GC is not tied to a specific ingress.

@rramkumar1
Copy link
Contributor

/assign

@nicksardo nicksardo added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 16, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 14, 2018
@rramkumar1
Copy link
Contributor

rramkumar1 commented Oct 31, 2018 •
edited
Loading

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 31, 2018
@rramkumar1
Copy link
Contributor

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Oct 31, 2018
@swetharepakula
Copy link
Member

Closing. GC events have been added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rramkumar1 rramkumar1

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@nicksardo @freehan @swetharepakula @k8s-ci-robot @rramkumar1 @fejta-bot