Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress for Multi-Zone Clusters #52

Closed
6 of 22 tasks
aronchick opened this issue Jul 22, 2016 · 27 comments
Closed
6 of 22 tasks

Ingress for Multi-Zone Clusters #52

aronchick opened this issue Jul 22, 2016 · 27 comments
Assignees
Labels
sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster.
Milestone

Comments

@aronchick
Copy link
Contributor

aronchick commented Jul 22, 2016

Description

Provide ingress for multi-zone clusters. This description will be fleshed out by @quinton-hoole.

Progress Tracker

  • Before Alpha
    • Write and maintain draft quality doc
      • During development keep a doc up-to-date about the desired experience of the feature and how someone can try the feature in its current state. Think of it as the README of your new feature and a skeleton for the docs to be written before the Kubernetes release. Paste link to Google Doc: DOC-LINK
    • Design Approval
      • Design Proposal. This goes under docs/proposals. Doing a proposal as a PR allows line-by-line commenting from community, and creates the basis for later design documentation. Paste link to merged design proposal here: PROPOSAL-NUMBER
      • Initial API review (if API). Maybe same PR as design doc. PR-NUMBER
        • Any code that changes an API (/pkg/apis/...)
        • cc @kubernetes/api
      • Identify shepherd (your SIG lead and/or [email protected] will be able to help you). My Shepherd is: [email protected] (and/or GH Handle)
        • A shepherd is an individual who will help acquaint you with the process of getting your feature into the repo, identify reviewers and provide feedback on the feature. They are not (necessarily) the code reviewer of the feature, or tech lead for the area.
        • The shepherd is not responsible for showing up to Kubernetes-PM meetings and/or communicating if the feature is on-track to make the release goals. That is still your responsibility.
      • Identify secondary/backup contact point. My Secondary Contact Point is: [email protected] (and/or GH Handle)
    • Write (code + tests + docs) then get them merged. ALL-PR-NUMBERS
      • Code needs to be disabled by default. Verified by code OWNERS
      • Minimal testing
      • Minimal docs
        • cc @kubernetes/docs on docs PR
        • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
        • New apis: Glossary Section Item in the docs repo: kubernetes/kubernetes.github.io
      • Update release notes
  • Before Beta
    • Testing is sufficient for beta
    • User docs with tutorials
      • Updated walkthrough / tutorial in the docs repo: kubernetes/kubernetes.github.io
      • cc @kubernetes/docs on docs PR
      • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
    • Thorough API review
      • cc @kubernetes/api
  • Before Stable
    • docs/proposals/foo.md moved to docs/design/foo.md
      • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
    • Soak, load testing
    • detailed user docs and examples
      • cc @kubernetes/docs
      • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off

FEATURE_STATUS is used for feature tracking and to be updated by @kubernetes/feature-reviewers.
FEATURE_STATUS: IN_DEVELOPMENT

More advice:

Design

  • Once you get LGTM from a @kubernetes/feature-reviewers member, you can check this checkbox, and the reviewer will apply the "design-complete" label.

Coding

  • Use as many PRs as you need. Write tests in the same or different PRs, as is convenient for you.
  • As each PR is merged, add a comment to this issue referencing the PRs. Code goes in the http://github.com/kubernetes/kubernetes repository,
    and sometimes http://github.com/kubernetes/contrib, or other repos.
  • When you are done with the code, apply the "code-complete" label.
  • When the feature has user docs, please add a comment mentioning @kubernetes/feature-reviewers and they will
    check that the code matches the proposed feature and design, and that everything is done, and that there is adequate
    testing. They won't do detailed code review: that already happened when your PRs were reviewed.
    When that is done, you can check this box and the reviewer will apply the "code-complete" label.

Docs

  • Write user docs and get them merged in.
  • User docs go into http://github.com/kubernetes/kubernetes.github.io.
  • When the feature has user docs, please add a comment mentioning @kubernetes/docs.
  • When you get LGTM, you can check this checkbox, and the reviewer will apply the "docs-complete" label.
@aronchick aronchick added this to the v1.4 milestone Jul 22, 2016
@aronchick aronchick assigned ghost Jul 22, 2016
@ghost
Copy link

ghost commented Jul 22, 2016

I believe that this is the "fix Ingress for multi-zone clusters" that @bprashanth is working on? Could someone please re-assign, as I don't seem to have the required permission on this repo. Thanks.

@bprashanth
Copy link

I haven't read the entire proposal, but multizone will already work. You just won't stay local to your zone, which I'm assuming most people want. kube-proxy is not zone aware so if you get a request in 1c it can send you to 1b instead.

To actually "fix" multizone, you need 2 clusters, one in 1c and one in 1b. Then kubeproxy will only keep you local, and the l7 will do smart anycast ip routing things.

@ghost
Copy link

ghost commented Jul 22, 2016

@bprashanth Yes, not staying in local zone is the desired behavior. I was under the impression that there was some bug involving the confluence of Ingress and Multi-zone clusters, that we were planning to fix. I'll try to find the issue tracking it.

@ghost
Copy link

ghost commented Jul 22, 2016

Either way, I don't think that fixing a bug is worthy of this heavy-handed release process. I assume that this is cut-n-paste gone awry @aronchick ?

@aronchick
Copy link
Contributor Author

No, it's our intent to publish features so the community understands what's
coming. If it's just a bug, then I misunderstood this feature.

On Fri, Jul 22, 2016 at 4:03 PM, Quinton Hoole [email protected]
wrote:

Either way, I don't think that fixing a bug is worthy of this heavy-handed
release process. I assume that this is cut-n-paste gone awry @aronchick
https://github.com/aronchick ?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#52 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADIdf-uBy9pBJXWt4O1kFy2Sr2Bfggjks5qYUw9gaJpZM4JTIkr
.

@bprashanth
Copy link

that bug was fixed for 1.3

@bprashanth
Copy link

it still needs good e2es, though

@aronchick
Copy link
Contributor Author

Completed in 1.3.

@bprashanth
Copy link

Looking through that list, the feature would be in alpha. There are no user docs, tutorials and no thorough testing (load, soak etc). It is implemented, with minimal testing, so I'm fine keeping this open since ~50% is accurate.

@aronchick aronchick reopened this Jul 22, 2016
@aronchick aronchick assigned bprashanth and unassigned ghost Jul 22, 2016
@idvoretskyi
Copy link
Member

@aronchick @bprashanth @quinton-hoole gentlemen, can you polish the description (including shepherd, referenced SIG etc.)? Thank you.

@idvoretskyi idvoretskyi added the sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. label Jul 25, 2016
@idvoretskyi
Copy link
Member

@aronchick @bprashanth @quinton-hoole folks, any updates?

@bprashanth
Copy link

The work that remains is testing+docs. Given how we structure these releases, I don't plan to spend any time on that till after the point when i can no longer check in other "features".

@bprashanth
Copy link

By testing i mean load and soak testing, we already have basic tests

@idvoretskyi
Copy link
Member

@bgrant0607 #64 should fix that.

@alex-mohr
Copy link

@matchstick Still on track for Friday, I assume?

@bprashanth
Copy link

#52 (comment) is accurate

@ghost ghost changed the title Provide Ingress for Multi-Zone Clusters Ingress for Multi-Zone Clusters Aug 25, 2016
@janetkuo
Copy link
Member

janetkuo commented Sep 2, 2016

@bprashanth Are the docs ready? Please update the docs in https://github.com/kubernetes/kubernetes.github.io, and then add PR numbers and check the docs box in the issue description

@bprashanth
Copy link

The docs for this are actually the same as the docs for the normal ingress (creating all existing examples: http://kubernetes.io/docs/user-guide/ingress/ in a multi zone cluster works the same way). there's some clarity I can add around this NOT working on various other non cloudprovider ingress controllers, but I plan to do that post test deflaking.

Loadbalancer load e2es that didn't make it in time though, because we have a general lack of testing infra for that sort of thing (long lived high load testing). Planned for 1.5.

@bprashanth
Copy link

Oh, load testing is only for beta. Great then this is pretty much done with alpha modulo the clarification mentioned in previous post (I can't edit the issue description).

@jaredbhatti
Copy link

@bprashanth Just checking: Are you stating that docs aren't required for this feature?

@jaredbhatti
Copy link

@bprashanth Another ping on docs. Any PRs you can point me to? Does this need docs at all?

@bprashanth
Copy link

adding clarifications by eod

@idvoretskyi
Copy link
Member

@bprashanth so, what is the actual status for docs (as @jaredbhatti mentioned above)?

@bprashanth
Copy link

kubernetes/website#1261

@ghost
Copy link

ghost commented Sep 30, 2016

Released alpha in v1.4

@ghost ghost closed this as completed Sep 30, 2016
@idvoretskyi
Copy link
Member

@quinton-hoole are you going to continue development in 1.5 for this feature?

@ghost
Copy link

ghost commented Oct 6, 2016

It's not on my radar. @bprashanth is planning and executing.

On Oct 6, 2016 01:59, "Ihor Dvoretskyi" [email protected] wrote:

@quinton-hoole https://github.com/quinton-hoole are you going to
continue development in 1.5 for this feature?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#52 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ6NAaqn9UNmNlkBw7cxBJkIKTeGAXWIks5qxLhwgaJpZM4JTIkr
.

ingvagabund pushed a commit to ingvagabund/enhancements that referenced this issue Apr 2, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster.
Projects
None yet
Development

No branches or pull requests

7 participants