Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-127: Fix user namespaces feature gate name #4107

Merged
merged 1 commit into from
Jun 20, 2023
Merged

KEP-127: Fix user namespaces feature gate name #4107

merged 1 commit into from
Jun 20, 2023

Conversation

saschagrunert
Copy link
Member

  • One-line PR description: The actual feature gate name is UserNamespacesStatelessPodsSupport, which should be reflected in the KEP as well.

@saschagrunert
KEP-127: Fix user namespaces feature gate name
9553e22 
The actual feature gate name is `UserNamespacesStatelessPodsSupport`,
which should be reflected in the KEP as well.

Signed-off-by: Sascha Grunert <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 20, 2023
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 20, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Jun 20, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2023
giuseppe
giuseppe reviewed Jun 20, 2023
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't be better to change the other way around now that we are working on stateful support? The PR I have opened should be enough to support pods with volumes

SergeyKanzhelev
SergeyKanzhelev approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @derekwaynecarr
(formal approver of the KEP)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, saschagrunert, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 78f729a into kubernetes:master Jun 20, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 20, 2023
@saschagrunert saschagrunert deleted the user-namespaces-feature-gate branch June 21, 2023 06:39
@pacoxu pacoxu mentioned this pull request Sep 5, 2023
Open
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuseppe giuseppe giuseppe left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@mrunalp mrunalp mrunalp approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@derekwaynecarr derekwaynecarr

@SergeyKanzhelev SergeyKanzhelev

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
7 participants
@saschagrunert @bart0sh @k8s-ci-robot @mrunalp @giuseppe @SergeyKanzhelev @derekwaynecarr