Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trivial: fix broken link markdown #1939

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Conversation

tpepper
Copy link
Member

@tpepper tpepper commented Aug 14, 2020

In-page link was [text][url] instead of text.

Signed-off-by: Tim Pepper [email protected]

In-page link was [text][url] instead of [text](url).

Signed-off-by: Tim Pepper <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Aug 14, 2020
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels Aug 14, 2020
@tpepper tpepper requested review from rata and removed request for mattfarina and prydonius August 14, 2020 20:24
@rata
Copy link
Member

rata commented Aug 14, 2020

@tpepper thanks for the fix! This KEP is mostly driven on SIG-node now (instead of sig-apps), though, so assigning to @derekwaynecarr. The open PR moves it to the sig-node folder.

Not sure if I can lgtm on this repo or only core kubernetes, let's see:
/lgtm
/assign @derekwaynecarr

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2020
@rata
Copy link
Member

rata commented Aug 14, 2020

If you think it is easier, I can cherry-pick the commit to the open PR also

@tpepper
Copy link
Member Author

tpepper commented Aug 14, 2020

I can rebase on that other PR if it merges.

@rata
Copy link
Member

rata commented Aug 17, 2020

I'm fine with all. I think merging this PR might be the simplest way. Let's see :)

Thanks again for the fix :)

@mattfarina
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattfarina, tpepper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit 534ca4f into kubernetes:master Aug 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants