Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot Support for Kubernetes (CRD + External Controller) #543

Closed
xing-yang opened this issue Jan 19, 2018 · 20 comments
Closed

Snapshot Support for Kubernetes (CRD + External Controller) #543

xing-yang opened this issue Jan 19, 2018 · 20 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status

Comments

@xing-yang
Copy link
Contributor

xing-yang commented Jan 19, 2018

Feature Description

  • One-line feature description (can be used as a release note): Snapshot/restore functionality for Kubernetes and CSI. This provides standardized APIs design (CRDs) and adds PV snapshot/restore support for CSI volume drivers.
  • Primary contact (assignee): @jingxu97 @xing-yang
  • Responsible SIGs: @kubernetes/sig-storage-feature-requests
  • Design proposal link (community repo): CSI snapshot design community#2335
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
    @saad-ali
    @jsafrane
  • Approver (likely from SIG/area to which feature belongs):
    @thockin
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y): 1.12
    • Beta release target (x.y): 1.13
    • Stable release target (x.y): 1.14
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 19, 2018
@k8s-ci-robot
Copy link
Contributor

@xing-yang: Reiterating the mentions to trigger a notification:
@kubernetes/sig-storage-feature-requests

In response to this:

Feature Description

  • One-line feature description (can be used as a release note): Move snapshot support in-tree.
  • Primary contact (assignee): @jingxu97 @xing-yang
  • Responsible SIGs: @kubernetes/sig-storage-feature-requests
  • Design proposal link (community repo): Add Volume Snapshot Support Proposal community#1624
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
    @saad-ali
    @jsafrane
  • Approver (likely from SIG/area to which feature belongs):
    @thockin
  • Feature target (which target equals to which milestone):
  • Alpha release target (x.y): 1.10
  • Beta release target (x.y): 1.11
  • Stable release target (x.y): 1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xing-yang
Copy link
Contributor Author

@kubernetes/sig-storage-feature-requests

@k8s-ci-robot
Copy link
Contributor

@xing-yang: Reiterating the mentions to trigger a notification:
@kubernetes/sig-storage-feature-requests

In response to this:

@kubernetes/sig-storage-feature-requests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@idvoretskyi
Copy link
Member

/assign @jingxu97 @xing-yang

@idvoretskyi idvoretskyi added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 22, 2018
@idvoretskyi idvoretskyi added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 29, 2018
@idvoretskyi idvoretskyi added this to the v1.10 milestone Jan 29, 2018
@saad-ali saad-ali modified the milestones: v1.10, next-milestone Feb 16, 2018
@saad-ali
Copy link
Member

We're moving this to 1.11. For this quarter the focus is on coming up with a Restore API and CSI implementation (both out-of-tree)

@mlmhl
Copy link

mlmhl commented Mar 29, 2018

Do we have any plan for this feature in 1.11? @saad-ali @jingxu97 @xing-yang

@xing-yang
Copy link
Contributor Author

@mlmhl We'll discuss about it in today's sig-storage planning meeting and make a decision.

@xing-yang
Copy link
Contributor Author

@mlmhl We have agreed to work on this and target for 1.11 Alpha.

@mlmhl
Copy link

mlmhl commented Mar 30, 2018

Thanks @xing-yang . My team is very looking forward to this feature, and I can help to move along this feature if you needed.

@xing-yang
Copy link
Contributor Author

Thanks @mlmhl! I'll keep that in mind.

@idvoretskyi
Copy link
Member

@xing-yang @saad-ali @kubernetes/sig-storage-feature-requests can you confirm that this feature is planned for 1.11?

/cc @justaugustus

@xing-yang
Copy link
Contributor Author

@idvoretskyi Yes, we are targeting this feature for 1.11.

@saad-ali saad-ali modified the milestones: next-milestone, v1.11 Apr 12, 2018
@mdlinville
Copy link

@xing-yang @jingxu97 please fill out the appropriate line item of the
1.11 feature tracking spreadsheet
and open a placeholder docs PR against the
release-1.11 branch
by 5/25/2018 (tomorrow as I write this) if new docs or docs changes are
needed and a relevant PR has not yet been opened.

@xing-yang
Copy link
Contributor Author

@MistyHacks We are delaying this to 1.12. Thanks.

@mdlinville
Copy link

@justaugustus @idvoretskyi FYI

@idvoretskyi idvoretskyi modified the milestones: v1.11, v1.12 Jun 1, 2018
@justaugustus justaugustus removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 1, 2018
@justaugustus
Copy link
Member

@xing-yang @jingxu97 @kubernetes/sig-storage-feature-requests --

This feature was removed from the previous milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

/cc @justaugustus @kacole2 @robertsandoval @rajendar38

@tpepper
Copy link
Member

tpepper commented Jul 24, 2018

Is this still targeting 1.12, or does moving to CRD slow and put the implementation at risk?

@xing-yang
Copy link
Contributor Author

@tpepper @justaugustus Yes, this is still targeting 1.12. Thanks.

@justaugustus justaugustus added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 25, 2018
@justaugustus
Copy link
Member

justaugustus commented Jul 25, 2018

Thanks for the update! This has been added to the 1.12 Tracking sheet.

@saad-ali saad-ali changed the title Move Snapshot Support in-tree Snapshot Support for Kubernetes (CRD + External Controller) Jul 27, 2018
@saad-ali
Copy link
Member

Looks like this is a duplicate of #177

Closing this issue. Please put further updates on #177

@justaugustus justaugustus removed this from the v1.12 milestone Jul 28, 2018
@justaugustus justaugustus removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
None yet
Development

No branches or pull requests

9 participants