This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
[nginx-ingress-controller]: Add function helpers to nginx template #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bprashanth ping |
|
For my own edification, can you elaboration how one leverages this, do we need a custom template (haven't parsed the entire issue)? |
Yes. This PR just add new helpers to the template to avoid compiling a custom controller like in #1695 |
tjliupeng
approved these changes
Sep 18, 2016
|
@bprashanth ping |
|
recomputing cla status... |
k8s-github-robot
added
the
cncf-cla: yes
|
LGTM, please document an example of how one uses it so the wider community can avail of the new functions (ok to do this in a follow up pr) |
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Sep 26, 2016
Automatic merge from submit-queue [nginx-ingress-controller] Add docs about go template Address #1711 (comment)
aledbf
pushed a commit
to aledbf/contrib
that referenced
this pull request
Nov 10, 2016
…funcmap Automatic merge from submit-queue [nginx-ingress-controller]: Add function helpers to nginx template fixes kubernetes-retired#1695
aledbf
pushed a commit
to aledbf/contrib
that referenced
this pull request
Nov 10, 2016
Automatic merge from submit-queue [nginx-ingress-controller] Add docs about go template Address kubernetes-retired#1711 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1695
This change is