Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

[nginx-ingress-controller]: Add HTTPS default backend #1338

Merged
merged 2 commits into from
Jul 20, 2016

Conversation

aledbf
Copy link
Contributor

@aledbf aledbf commented Jul 8, 2016

fixes #1331
fixes #1329

@aledbf aledbf changed the title WIP [nginx-ingress-controller]: Add HTTPS default backend [nginx-ingress-controller]: Add HTTPS default backend Jul 18, 2016
@bprashanth
Copy link

LGTM

@bprashanth bprashanth merged commit 96831e2 into kubernetes-retired:master Jul 20, 2016
@aledbf aledbf deleted the ssl-default-backend branch July 20, 2016 19:36
@gambol99
Copy link

Post this merge i'm getting the following error, with SSL no longer working ...

2016/07/21 11:27:30 [error] 24#24: *224 no "ssl_certificate" is defined in server listening on SSL port while SSL handshaking, client: 10.10.4.1, server: 0.0.0.0:443
2016/07/21 11:27:30 [error] 24#24: *225 no "ssl_certificate" is defined in server listening on SSL port while SSL handshaking, client: 10.10.4.1, server: 0.0.0.0:443

I has to remove the section below to fix it

{{/* Check for default SSL backend */}}
 +    {{ if and (eq $server.Name "_") (not $server.SSL) -}}
 +    server {
 +        server_name {{ $server.Name }};
 +        listen 443;
 +        # return protocol error.
 +        return 444;
 +    }
 +    {{ end }}

@aledbf
Copy link
Contributor Author

aledbf commented Jul 25, 2016

@gambol99 this issue was fixed in #1393.

aledbf pushed a commit to aledbf/contrib that referenced this pull request Nov 10, 2016
…ckend

[nginx-ingress-controller]: Add HTTPS default backend
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants