This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
[nginx-ingress-controller] Add ssl certificate checksum to template #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aledbf
changed the title
|
cherry-picked with #1063 and works perfectly in my cluster LGTM |
| @@ -155,6 +155,7 @@ http { | |||
| server { | |||
| listen 80{{ if $cfg.useProxyProtocol }} proxy_protocol{{ end }}; | |||
| {{ if $server.SSL }}listen 443{{ if $cfg.useProxyProtocol }} proxy_protocol{{ end }} ssl http2; | |||
| # PEM sha: {{ $server.SSLPemChecksum }} | |||
There was a problem hiding this comment.
Is just a comment. If the secret changes this comment will trigger the reload (diff with the current running cfg)
There was a problem hiding this comment.
oh, hmm. suggest adding a commet about the significance of that comment.
aledbf
force-pushed
the
cert-checksum
branch
2 times, most recently
from
2eb8dd1
to
4d8cf3d
Compare
|
Thanks, LGTM |
aledbf
pushed a commit
to aledbf/contrib
that referenced
this pull request
Nov 10, 2016
[nginx-ingress-controller] Add ssl certificate checksum to template
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #800