Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API conventions give incorrect Conditions advice #4471

Closed
jpeach opened this issue Jan 30, 2020 · 7 comments · Fixed by #4521
Closed

API conventions give incorrect Conditions advice #4471

jpeach opened this issue Jan 30, 2020 · 7 comments · Fixed by #4521
Labels
area/developer-guide Issues or PRs related to the developer guide sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Milestone
v1.19

Comments

@jpeach
Copy link

jpeach commented Jan 30, 2020

As per this comment the advice the API conventions document gives about .status.conventions is wrong. This should be corrected so that projects trying to be good API participants can define interoperable Conditions behavior.
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 30, 2020
@jpeach
Copy link
Author

jpeach commented Jan 30, 2020

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 30, 2020
@jpeach
Copy link
Author

jpeach commented Jan 30, 2020

xref kubernetes-sigs/gateway-api#47

@jpeach jpeach mentioned this issue Jan 30, 2020
Merged
@evankanderson
Copy link
Contributor

@smarterclayton if you think this is sufficiently established case law, I'm happy to send a PR to distill some of the wisdom.

@smarterclayton
Copy link
Contributor

Yeah I think so, @liggitt if he wants to disagree

@mrbobbytables mrbobbytables added the area/developer-guide Issues or PRs related to the developer guide label Feb 13, 2020
@evankanderson evankanderson mentioned this issue Feb 14, 2020
Merged
@mrbobbytables mrbobbytables added this to the Next milestone Mar 11, 2020
@mrbobbytables mrbobbytables added the sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. label Mar 11, 2020
@mrbobbytables mrbobbytables modified the milestones: Next, v1.19 Apr 22, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 21, 2020
@evankanderson
Copy link
Contributor

Still discussing #4521

@evankanderson
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/developer-guide Issues or PRs related to the developer guide sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Projects
None yet
Milestone
v1.19
Development

Successfully merging a pull request may close this issue.

Update Condition guidance evankanderson/k8s-community
6 participants
@jpeach @smarterclayton @mrbobbytables @evankanderson @k8s-ci-robot @fejta-bot