-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup(vpa): remove go vendoring for e2e #7573
cleanup(vpa): remove go vendoring for e2e #7573
Conversation
Signed-off-by: David van der Spek <[email protected]>
Signed-off-by: David van der Spek <[email protected]>
Signed-off-by: David van der Spek <[email protected]>
Hi @davidspek. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/test pull-kubernetes-e2e-autoscaling-vpa-full |
Signed-off-by: David van der Spek <[email protected]>
/lgtm |
/assign kgolab |
/assign gjtempleton since this changes a file in the hack/ directory and you recently approved a PR with a similar change. |
/assign raywainman For the VPA part of the changes |
Thanks so much for the cleanup. /lgtm /approve |
Thanks for this! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidspek, gjtempleton, raywainman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR removes the
e2e/vendor
directory for the VPA. Vendoring the dependencies into the repo not only increases the size, but also makes reviewing PRs that include dependency changes more difficult. Sometimes to the point of breaking the GitHub UI like in #7551 and likely this PR.Which issue(s) this PR fixes:
Fixes #7570
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: