Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA: DRA integration MVP #7530

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
+5,411 −152
Open

CA: DRA integration MVP #7530

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c2b37e5
CA: implement utils for interacting with ResourceClaims
towca Dec 9, 2024
75c217a
CA: implement dynamicresources.Snapshot for storing and modifying the…
towca Dec 9, 2024
319484b
CA: implement a Provider for dynamicresources.Snapshot
towca Dec 9, 2024
6eba929
CA: sanitize and propagate DRA objects through NodeInfos in node_info…
towca Sep 30, 2024
ec1232d
CA: implement calculating utilization for DRA resources
towca Oct 1, 2024
8a8ac0e
CA: add DRA object handling logic to PredicateSnapshot
towca Nov 21, 2024
a90d3d8
CA: plumb the DRA provider to SetClusterState callsites, grab and pas…
towca Nov 21, 2024
b952788
CA: implement DRA integration tests for StaticAutoscaler
towca Nov 21, 2024
4566ca6
CA: automatically use BasicSnapshotStore when DRA is enabled
towca Dec 10, 2024
fec30d3
CA: enable the DRA feature gate whenever the DRA flag is passed
towca Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion cluster-autoscaler/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import (
"k8s.io/autoscaler/cluster-autoscaler/provisioningrequest/besteffortatomic"
"k8s.io/autoscaler/cluster-autoscaler/provisioningrequest/checkcapacity"
"k8s.io/autoscaler/cluster-autoscaler/provisioningrequest/provreqclient"
"k8s.io/autoscaler/cluster-autoscaler/simulator/clustersnapshot"
"k8s.io/autoscaler/cluster-autoscaler/simulator/clustersnapshot/predicate"
"k8s.io/autoscaler/cluster-autoscaler/simulator/clustersnapshot/store"
"k8s.io/autoscaler/cluster-autoscaler/simulator/framework"
Expand Down Expand Up @@ -503,10 +504,16 @@ func buildAutoscaler(context ctx.Context, debuggingSnapshotter debuggingsnapshot
deleteOptions := options.NewNodeDeleteOptions(autoscalingOptions)
drainabilityRules := rules.Default(deleteOptions)

var snapshotStore clustersnapshot.ClusterSnapshotStore = store.NewDeltaSnapshotStore()
if autoscalingOptions.DynamicResourceAllocationEnabled {
// TODO(DRA): Remove this once DeltaSnapshotStore is integrated with DRA.
snapshotStore = store.NewBasicSnapshotStore()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some high level log/warning here, this might not be expected for the end-user.

}

opts := core.AutoscalerOptions{
AutoscalingOptions: autoscalingOptions,
FrameworkHandle: fwHandle,
ClusterSnapshot: predicate.NewPredicateSnapshot(store.NewDeltaSnapshotStore(), fwHandle, autoscalingOptions.DynamicResourceAllocationEnabled),
ClusterSnapshot: predicate.NewPredicateSnapshot(snapshotStore, fwHandle, autoscalingOptions.DynamicResourceAllocationEnabled),
KubeClient: kubeClient,
InformerFactory: informerFactory,
DebuggingSnapshotter: debuggingSnapshotter,
Expand Down