Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick 3308 onto 1.19 - Fix priority expander falling back to random although higher priority matches #3582

Merged
merged 4 commits into from
Oct 8, 2020
Merged

Cherry pick 3308 onto 1.19 - Fix priority expander falling back to random although higher priority matches #3582

merged 4 commits into from
Oct 8, 2020

Conversation

nitrag
Copy link
Contributor

@nitrag nitrag commented Oct 5, 2020

Cherry pick #3308 onto 1.19

vivekbagade and others added 3 commits July 30, 2020 16:36
@vivekbagade
Cluster Autoscaler 1.19.0
c753e45
@k8s-ci-robot
Merge pull request kubernetes#3381 from vivekbagade/cluster-autoscale…
db76938 
…r-release-1.19

Cluster Autoscaler 1.19.0
@k8s-ci-robot @nitrag
Merge pull request kubernetes#3308 from bruecktech/fix-fallback
0e4a077 
Fix priority expander falling back to random although higher priority matches
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 5, 2020
@nitrag
Copy link
Contributor Author

nitrag commented Oct 5, 2020

@MaciekPytel you previously recommended I do this in #3308

mwielgus
mwielgus suggested changes Oct 7, 2020
View reviewed changes
cluster-autoscaler/version/version.go Outdated Show resolved Hide resolved
@nitrag
Copy link
Contributor Author

nitrag commented Oct 8, 2020

@mwielgus Fixed

mwielgus
mwielgus approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit d34e434 into kubernetes:master Oct 8, 2020
@cablespaghetti
Copy link
Contributor

@mwielgus @nitrag This seems to have been merged to the wrong branch. This is still broken on the 1.19 branch. 😞

https://github.com/kubernetes/autoscaler/blob/cluster-autoscaler-release-1.19/cluster-autoscaler/expander/priority/priority.go

This was referenced Mar 19, 2021
Closed
Closed
@nitrag nitrag mentioned this pull request Mar 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus mwielgus approved these changes

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nitrag @k8s-ci-robot @cablespaghetti @mwielgus @vivekbagade