Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation used to exclude Nodes from the autoscaler check uses invalid key #6300

Closed
brydoncheyney opened this issue Nov 20, 2023 · 0 comments · Fixed by #6301
Closed

Annotation used to exclude Nodes from the autoscaler check uses invalid key #6300

brydoncheyney opened this issue Nov 20, 2023 · 0 comments · Fixed by #6301
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@brydoncheyney
Copy link
Contributor

brydoncheyney commented Nov 20, 2023

Which component are you using?: cluster-autoscaler

What version of the component are you using?: HEAD (feature is unreleased)

Component version: HEAD

What k8s version are you using (kubectl version)?: EKS 1.28

kubectl version Output
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.4", GitCommit:"fa3d7990104d7c1f16943a67f11b154b71f6a132", GitTreeState:"clean", BuildDate:"2023-07-19T12:14:48Z", GoVersion:"go1.20.6", Compiler:"gc", Platform:"darwin/arm64"}
Kustomize Version: v5.0.1
Server Version: version.Info{Major:"1", Minor:"28+", GitVersion:"v1.28.3-eks-4f4795d", GitCommit:"e77944ea667aee90c84c48a74a2a0da7a23e0508", GitTreeState:"clean", BuildDate:"2023-10-20T23:21:39Z", GoVersion:"go1.20.10", Compiler:"gc", Platform:"linux/amd64"}

What environment is this in?: AWS

What did you expect to happen?:

Applying the annotation to Nodes would reduce the levels of redundant messaging in the controller

What happened instead?:

Annotation could not be applied.

How to reproduce it (as minimally and precisely as possible):

; k patch node ip-XXX-XXX-XXX-XXX.ec2.internal --patch '{"metadata": {"annotations": {"k8s.io/cluster-autoscaler/enabled": "false"}}}'
The Node "ip-XXX-XXX-XXX-XXX.ec2.internal" is invalid: metadata.annotations: Invalid value: "k8s.io/cluster-autoscaler/enabled": a qualified name must consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyName',  or 'my.name',  or '123-abc', regex used for validation is '([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]') with an optional DNS subdomain prefix and '/' (e.g. 'example.com/MyName')

Anything else we need to know?:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant