Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: Adding aws csi zone label to a node template #6136

Closed
Shubham82 opened this issue Sep 25, 2023 · 8 comments
Closed

Backport: Adding aws csi zone label to a node template #6136

Shubham82 opened this issue Sep 25, 2023 · 8 comments
Assignees
@Shubham82
Labels
area/provider/aws Issues or PRs related to aws provider kind/feature Categorizes issue or PR as related to a new feature.

Comments

@Shubham82
Copy link
Contributor

Shubham82 commented Sep 25, 2023 •
edited
Loading

As per the following comment on PR #6090, from @msvticket, cherry-picked the changes on this to the previous releases of CA which will fix the issue #3845 in those releases.
@Shubham82
Copy link
Contributor Author

/kind feature
/area provider/aws

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/provider/aws Issues or PRs related to aws provider labels Sep 25, 2023
@Shubham82
Copy link
Contributor Author

I think we can do it.
cc @gjtempleton @drmorr0 what are your thoughts on this?

@Shubham82
Copy link
Contributor Author

if it seems good then I'm up for it.

/assign

@drmorr0
Copy link
Contributor

drmorr0 commented Sep 25, 2023

I think we can do it. cc @gjtempleton @drmorr0 what are your thoughts on this?

Go for it!

@Shubham82
Copy link
Contributor Author

Thanks, @drmorr0, I will open PR for it.

This was referenced Sep 26, 2023
Merged
Merged
Merged
Merged
Merged
@Shubham82
Copy link
Contributor Author

Raised the following PR to fix this issue:
For CA 1.28 #6146
For CA 1.27 #6145
For CA 1.26 #6144
For CA 1.25 #6143
For CA 1.24 #6142

@Shubham82
Copy link
Contributor Author

@drmorr0 could please take a look at the following PRs (Which are not merged), so that they will merge:
For CA 1.28 #6146
For CA 1.27 #6145
For CA 1.25 #6143
For CA 1.24 #6142

Thanks!

@Shubham82
Copy link
Contributor Author

closing this PR as all corresponding PRs are merged now.

Thanks @drmorr0 @gjtempleton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shubham82 Shubham82

Labels
area/provider/aws Issues or PRs related to aws provider kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@drmorr0 @k8s-ci-robot @Shubham82