[Magnum][ClusterAutoscaler] Error finding node group UUID for node

[modzilla99]

Which component/version are you using?:

cloud-provider: magnum
kubernetes-version: v1.26.0
cluster-autoscaler-ver: v1.26.1

What environment is this in?:
OpenStack

What did you expect to happen?:

The cluster autoscaler to ignore the control-plane nodes and the scaling to work

What happened instead?:

The cluster autoscaler can't find the nodegroup of the master nodes and no scaling is happening

How to reproduce it (as minimally and precisely as possible):

Deploy Kubernetes remove master role label and replace it with control-plane:

NAME                                          STATUS   ROLES                  AGE   VERSION   INTERNAL-IP   EXTERNAL-IP     OS-IMAGE                        KERNEL-VERSION           CONTAINER-RUNTIME
kubernetes-ci-cluster-yaarjcfo5gee-master-0   Ready    control-plane          2d    v1.27.1   10.0.0.144    1.1.1.1         Fedora CoreOS 37.20221211.3.0   6.0.12-300.fc37.x86_64   containerd://1.7.0

Anything else we need to know?:

The problem lies here:

https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/magnum/magnum_cloud_provider.go#LL124-L126

[modzilla99]

I also had to add the following to the Clusterrole when using the helm chart:

---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: cluster-autoscaler-role
rules:
  - apiGroups:
      - ""
    resources:
      - configmaps
    verbs:
      - get
      - update
    resourceNames:
      - cluster-autoscaler-status
      - cluster-autoscaler-priority-expander