Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster Autoscaler patch release - request for cherry-picks #2547

Closed
losipiuk opened this issue Nov 20, 2019 · 13 comments
Closed

Cluster Autoscaler patch release - request for cherry-picks #2547

losipiuk opened this issue Nov 20, 2019 · 13 comments

Comments

@losipiuk
Copy link
Contributor

The time has come!

We plan to prepare a set of Cluster Autoscaler patch releases beginning next week. Please issue cherry-picks if you want something in. Just a friendly reminder that as a rule of thumb only bugfixes are cherry-pickable.

cc: @feiskyer, @Jeffwan, @ringtail, @hello2mao, @tghartland

@tghartland
Copy link
Contributor

No bug fixes for magnum, I'm just working on the big upgrade to support magnum's node groups (I'll open an issue).

@Jeffwan
Copy link
Contributor

Jeffwan commented Nov 24, 2019

Thanks. I will check if any cherry-pick candidates.

@Jeffwan
Copy link
Contributor

Jeffwan commented Nov 26, 2019

@losipiuk We don't have bug fixes need to be back-ported besides this one. #2435

EKS right now support kubernetes cluster 1.11-1.14. It will take around 2-3 months to support 1.15. Right now, we don't have a version with priority expander support which is critical to our users, especially for spot instance use case. Could we backport this feature? I hope at least we have one version with priority expander support. Seems PR pass all the check.

@losipiuk
Copy link
Contributor Author

EKS right now support kubernetes cluster 1.11-1.14. It will take around 2-3 months to support 1.15. Right now, we don't have a version with priority expander support which is critical to > our users, especially for spot instance use case. Could we backport this feature? I hope at least we have one version with priority expander support. Seems PR pass all the check.

I will merge this as it is opt in - and therefore low risk

@losipiuk
Copy link
Contributor Author

losipiuk commented Nov 27, 2019

@Jeffwan O wait - I cannot merge #2435 because bot is complaining about "commit missing GitHub user". Can you guys fix that? I can wait with building 1.14 release till tomorrow. And merge the PR if you fix it and test today. SG?

@Jeffwan
Copy link
Contributor

Jeffwan commented Nov 27, 2019

@losipiuk Cool. Thank you. I will fix this issue and run some tests. Please hold 1.14 and I will try to make it asap.

@Jeffwan
Copy link
Contributor

Jeffwan commented Nov 27, 2019

We close #2435 and create a new PR with username correction #2578. @losipiuk Please have a check

@feiskyer
Copy link
Member

A few cherry picks #2570 #2571 #2572 #2567

@losipiuk
Copy link
Contributor Author

@stefanolczak
Copy link

@losipiuk why there are no 1.13 release ? Are you planning to release it anytime soon? There are few fixes already merged and we are really waiting for one of them - #2509

@losipiuk
Copy link
Contributor Author

losipiuk commented Dec 4, 2019

Łukasz Osipiuk why there are no 1.13 release ? Are you planning to release it anytime soon? There are few fixes already merged and we are really waiting for one of them - #2509

Actually I did not plan to do so. As k8s 1.13 is EOL. If you need that I will do the release by the end of this week.

@stefanolczak
Copy link

Łukasz Osipiuk why there are no 1.13 release ? Are you planning to release it anytime soon? There are few fixes already merged and we are really waiting for one of them - #2509

Actually I did not plan to do so. As k8s 1.13 is EOL. If you need that I will do the release by the end of this week.

Yes please - it will be very helpful for us. Thank you

@losipiuk
Copy link
Contributor Author

losipiuk commented Dec 6, 2019

Łukasz Osipiuk why there are no 1.13 release ? Are you planning to release it anytime soon? There are few fixes already merged and we are really waiting for one of them - #2509

Actually I did not plan to do so. As k8s 1.13 is EOL. If you need that I will do the release by the end of this week.

Yes please - it will be very helpful for us. Thank you

https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.13.9 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants