-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference Starlark Function #4126
Comments
/assign @KnVerey |
I agree that the path should not depend on the current working directory. It should be relative to the Kustomization including the transformer config, as we did for exec in #4125. That said, there is an open proposal that includes deprecating dedicated starlark support: kubernetes/enhancements#2954. Although it has its advantages, it is a problem for us to maintain and notably causes a permanent inconsistency with /triage accepted |
I was only curious about Starlark. Not too worried if it gets deprecated. I did like the idea of a dedicated scripting language for Kustomize. I am wondering though the direction of plugins vs functions in kustomize? Are plugins and functions two different ideas and one is going to win over the other? Or are they two separate ideas and they will live alongside each other? |
I'd characterize functions as a subcategory of plugins, and yes, the KEP proposes retaining function-style Exec and Container plugins only, and deprecating the rest. Please read the Motivation section for more background. |
@kferrone: This issue is currently awaiting triage. SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
new updates and new ideas. No need for this issue. Starlark is getting deprecated. |
I am particularly interested in using this example and modifying for myself: https://github.com/kubernetes-sigs/kustomize/tree/master/plugin/someteam.example.com/v1/starlarkmixer
My issue is the mixer.star file must be relative of where my terminal is. So if I dom something like
cd ../
the function will not reference the mixer.start anymore. I honestly would like to place the function in$XDG_CONFIG_HOME/kustomize/functions
.This way I always know where they are and they become reusable.
Here is the files I am using:
mixer.yaml
conf.yaml
kustomization.yaml
How can I safely share the mixer file with any function who want to use it?
Shouldn't the reference to these files be like every other kind of reference and be relative to the file it's in. Then the
$(pwd)
in the terminal would not matter.The text was updated successfully, but these errors were encountered: