Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove delegation to RNode in Resource #3885

Closed
monopole opened this issue May 11, 2021 · 0 comments · Fixed by #3888
Closed

Remove delegation to RNode in Resource #3885

monopole opened this issue May 11, 2021 · 0 comments · Fixed by #3888
Assignees

Comments

@monopole
Copy link
Contributor

monopole commented May 11, 2021

The core data structure of kustomize is a list of resource.Resource.

A Resource includes raw data about a resource (what one would send to a cluster) plus ancillary data used by kustomize to globally transform resources (e.g. update name back references when names change).

To close #2506, enabling the closure of #1500, kustomize was switched from depending on apimachinery Unstructured types inside resource.Resource to the relatively new kyaml module and its RNode type. Many of the signatures maintained by Resource now simply delegate to RNode, and this delegation can now be removed as a cleanup to #2506.

At some later point (not to close this PR) assure that the ancillary data in Resource (outside the RNode) is sent to and re-captured from transformer subprocess (as the process might edit the information). One way to do this would be to solely use RNode (YAML) annotation reading and writing instead of Resource struct data members.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant