-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Apply patches to name prefixed resources #316
Comments
In kustomize, the patch file doesn't need to include nameprefix in the object name since we don't want users to browse all files and calculate the proper name to use in the patch. But I do see that your use case is quite reasonable and Kustomize should support it. One possible solution is to add some enhancement on current applying patch process. When multiple objects are found for one patch, we can do a second round filtering by prefix. |
I think that makes sense. |
+1 |
This is becoming a problem in our situation. I have a couple of bases that are being reused in a single overlay. For example, the PersistentVolumeClaim of different Postgres bases need different sizes patched in. @Liujingfang1 Can you give some code pointers on where that second name matching round would need to be added? |
The fact that resources are referenced with their names without prefix and suffix applied could cause other issues such as #800 (just guessing though) |
Scenario: I have several instances (overlays) of an application (base) that I want to combine into combined Kustomizations to apply them as one.
In that Kustomization, I want to apply patches. If I use the un-prefixed name of a resource, the patch will be ambiguous. If I use the prefixed name, Kustomize cannot find the resource.
The text was updated successfully, but these errors were encountered: