-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version kustomization.yaml files #144
Comments
@r2d4 I took a look at your PR, you want to add the support of custom path instead of using current directory. In skaffold.yaml, you can add a field for this custom path and pass that to kustomize. |
Hi @Liujingfang1, the reference is not necessarily for the PR, but for the comment in the code. To get the file dependencies of the kustomization.yaml file, we would need to actually parse the YAML. To ensure that parsing doesn't break, we should parse it according to some well known version, e.g. |
@r2d4 |
If there are breaking changes to the kustomization.yaml, how will downstream tooling that reads or generates kustomize files know? |
@r2d4 we had this (standards k8s metadata / group-version-kind fields) and dropped it temporarily as, at the time, those fields weren't consumed by anything and in the case of a simple overlay (e.g. just adding a nameprefix) could double the size of the file. Decided to add them back as soon as we needed to make any kind of breaking change, or had a tool that exploited them. Should probably do it sooner rather than later to avoid confusion about how they'll be versioned. |
I'm hoping to do some parsing of the kustomization.yaml files and it would be helpful if the config was versioned. Maybe kubernetes style?
The text was updated successfully, but these errors were encountered: