Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dump cluster logs before bringing the cluster down #272

Closed
wants to merge 1 commit into from
Closed

Dump cluster logs before bringing the cluster down #272

wants to merge 1 commit into from

Conversation

soltysh
Copy link

@soltysh soltysh commented Oct 16, 2024

Fixes #271

/assign @BenTheElder

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: soltysh
Once this PR has been reviewed and has the lgtm label, please assign aojea for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2024
BenTheElder
BenTheElder reviewed Oct 31, 2024
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: we should probably dump cluster logs after test() even if we don't down() but this seems like a reasonable stopgap

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2024
@ameukam ameukam mentioned this pull request Nov 3, 2024
Merged
@aojea
Copy link
Contributor

aojea commented Nov 4, 2024

/close

I inadvertently slipped this one and merged other similar to this, just replacing the defer to avoid dumping logs twice

https://github.com/kubernetes-sigs/kubetest2/pull/273/files

@k8s-ci-robot
Copy link
Contributor

@aojea: Closed this PR.

In response to this:

/close

I inadvertently slipped this one and merged other similar to this, just replacing the defer to avoid dumping logs twice

https://github.com/kubernetes-sigs/kubetest2/pull/273/files

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@soltysh soltysh deleted the dump_logs_on_down branch November 5, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@chizhg chizhg Awaiting requested review from chizhg

@upodroid upodroid Awaiting requested review from upodroid

Assignees

@BenTheElder BenTheElder

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logs are obtained after the cluster is up and before the tests run
4 participants
@soltysh @k8s-ci-robot @aojea @BenTheElder