Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fallback download locations #8427

Closed
cristicalin opened this issue Jan 14, 2022 · 1 comment · Fixed by #8474
Closed

Support fallback download locations #8427

cristicalin opened this issue Jan 14, 2022 · 1 comment · Fixed by #8474
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@cristicalin
Copy link
Contributor

What would you like to be added:

Support in the download role for alternate download locations.

Why is this needed:

Project calico decided to shift their release assets download location with 3.21.3 and this breaks our download logic if we want to continue to support older versions that have their assets in the old locations (see https://github.com/projectcalico/calico/releases/tag/v3.21.3 and projectcalico/calico#5421).

To mitigate this issue I propose we modify the download role and implement a fallback logic with alternative download locations so that it would try all mirrors/alternatives if it gets 404s.

/cc @floryut @oomichi @Miouge1

@cristicalin cristicalin added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 14, 2022
@oomichi
Copy link
Contributor

oomichi commented Jan 14, 2022

@cristicalin
Thank you for your proposal.
This fallback download location proposal makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants