Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump cilium from v1.13.4 to v1.15.1 #10972

Closed
yankay opened this issue Mar 3, 2024 · 4 comments · Fixed by #11106
Closed

bump cilium from v1.13.4 to v1.15.1 #10972

yankay opened this issue Mar 3, 2024 · 4 comments · Fixed by #11106
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@yankay
Copy link
Member

yankay commented Mar 3, 2024

What would you like to be added

needs bump cilium from v1.13.4 to v1.15.1

differences:
cilium/cilium@v1.13.4...v1.15.1

release notes:
https://github.com/cilium/cilium/releases/tag/v1.15.1

Why is this needed

The cilium needs update to date

@yankay yankay added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 3, 2024
@mhkarimi1383
Copy link

mhkarimi1383 commented Mar 8, 2024

@yankay
Hi
Just change the version to v1.15.1 and you are good to go it was completely okay (with latest kubespray version)

@mkroman
Copy link

mkroman commented Mar 15, 2024

@yankay Hi Just change the version to v1.15.1 and you are good to go it was completely okay (with latest kubespray version)

That's not true. There's multiple CRD changes in v1.14 and later, e.g. for their BGP control-plane to work.

I updated the manifests in my own repo here: mkroman@d19fdc1

But I broke compatibility with the conditionals for earlier versions in the templates because maintaining it that way seems like a bad idea.

@mhkarimi1383
Copy link

@yankay Hi Just change the version to v1.15.1 and you are good to go it was completely okay (with latest kubespray version)

That's not true. There's multiple CRD changes in v1.14 and later, e.g. for their BGP control-plane to work.

I updated the manifests in my own repo here: mkroman@d19fdc1

But I broke compatibility with the conditionals for earlier versions in the templates because maintaining it that way seems like a bad idea.

Hi
There are for BGP stuff mostly
And Kubespray at the latest version supports up to 1.14.x
But I was completely Ok with 1.15.1

@deveshk0
Copy link
Contributor

deveshk0 commented Apr 22, 2024

@yankay I have opened a PR for this, can someone please have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants