Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A returned error is ignored in a test #4450

Closed
mogsie opened this issue Dec 29, 2024 · 0 comments · Fixed by #4452
Closed

A returned error is ignored in a test #4450

mogsie opened this issue Dec 29, 2024 · 0 comments · Fixed by #4452
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mogsie
Copy link
Contributor

mogsie commented Dec 29, 2024

What broke? What's expected?

The following line captures the output but ignores the error. Subsequently, the output is asserted not to contain some text.

If an error does occur here, the output will typically be empey, and will therefore not contain the text.

When developing kubebuilder, this ignored error could hold the key to why a test is failing.

The error should be captured and asserted not to have occurred.

Reproducing this issue

No response

KubeBuilder (CLI) Version

master

PROJECT version

No response

Plugin versions

No response

Other versions

No response

Extra Labels

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant