-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
controller-gen is unable to work with addons projects. #1525
Comments
/kind bug |
/assign @camilamacedo86 |
I am pushing the PR with the fix. |
This was referenced May 26, 2020
I checked that stuck behaviour:
However, it will break the CI. Any change in the repo will change the go.mod scaffolded by default and also can result in a breaking change which is the same scenario of; #1503 and indeed it can introduce a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug
When addon projects, such as follows are scaffolded, the go mod is updated with the latest version/commit of module kubernetes-sigs
/kubebuilder-declarative-pattern. The module has not been working with releases/tags and kb is not scaffolding a specific version and then, after the commit/version
v0.0.0-20200512162422-ce639cbf6d4c
the make targets which are using the controller-gen has been kept stuck.Notes
make check-testdata
to the prow CI #1503Suggested Solution
--pattern=addon
flag and using it.The text was updated successfully, but these errors were encountered: