Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Support set default value to the configuration #695

Closed
k82cn opened this issue Apr 2, 2019 · 6 comments · Fixed by #698
Closed

Support set default value to the configuration #695

k82cn opened this issue Apr 2, 2019 · 6 comments · Fixed by #698
Assignees
@hex108
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Milestone
v0.5

Comments

@k82cn
Copy link
Contributor

k82cn commented Apr 2, 2019

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

Description:

Currently, we dependent on YAML's default value for the configuration of plugin, for example , we have to say "disableJobOrder" because YAML's default vaule of bool is false :(

One solution is to set the member of PluginConf to be a pointer and have a setDefaultFunc for default values.
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 2, 2019
@k82cn k82cn added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Apr 2, 2019
@k82cn k82cn added this to the v0.5 milestone Apr 2, 2019
@k82cn k82cn added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Apr 2, 2019
@hex108
Copy link
Contributor

hex108 commented Apr 2, 2019

What default values need setDefaultFunc set? Disable them all by default?

@k82cn
Copy link
Contributor Author

k82cn commented Apr 2, 2019 •
edited
Loading

Disable them all by default?

Nop; I'd like to rename disableJobOrder to jobOrder, and enable them by default. And we need to have one more configuration, named Cachable, for eCache to disable pod affinity/anti-affinity.

@hex108
Copy link
Contributor

hex108 commented Apr 2, 2019

That's great!

@hex108
Copy link
Contributor

hex108 commented Apr 2, 2019

/assign

@hex108
Copy link
Contributor

hex108 commented Apr 2, 2019

@k82cn How about renaming disableJobOrder to enableJobOrder?

@k82cn
Copy link
Contributor Author

k82cn commented Apr 2, 2019

How about renaming disableJobOrder to enableJobOrder?

that's ok to me :)

@hex108 hex108 mentioned this issue Apr 2, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hex108 hex108

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Milestone
v0.5
Development

Successfully merging a pull request may close this issue.

Add support for setting default value to the configuration hex108/kube-batch
3 participants
@hex108 @k82cn @k8s-ci-robot