Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Timestamp of created kind cluster #1949

Closed
prankul88 opened this issue Dec 2, 2020 · 7 comments
Closed

Show Timestamp of created kind cluster #1949

prankul88 opened this issue Dec 2, 2020 · 7 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@prankul88
Copy link

What would you like to be added:
Would be helpful if kind get clusters can show the age of the created cluster. / Or we can add an option like -o wide to get more info.

For eg like,

Name                  Age
kind                  30m
capi-quickstart       15m

Why is this needed:
This can provide a better experience to the end user.

Note: Apologies if I might be missing something if this thing can be acheived through some other command.

@prankul88 prankul88 added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 2, 2020
@BenTheElder BenTheElder added kind/design Categorizes issue or PR as related to design. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Dec 2, 2020
@msscaroso
Copy link

/assign

@BenTheElder
Copy link
Member

Please see the contributor guide https://kind.sigs.k8s.io/docs/contributing/getting-started/

In particular, we'd really appreciate a discussion of what this will look like and how it might be implemented etc. before sending a PR, so we can discuss what we'd like do here and how it will be supported before you spend a lot of time writing the code and we spend time trying to review it.

I think there's actually a lot to consider here in terms of what the formatting flags should be like, what the default should be like, etc.

For example, if you change the default output, you will break many user scripts.

@msscaroso
Copy link

msscaroso commented Dec 11, 2020

@BenTheElder I think it is safe to assume kind get clusters should keep returning the same output as it is today, cause it is a breaking change and the benefits doesn't seem to justify the trouble of doing it.

So, apparently, formatting flags are the way to go.

Have you thought about it already? Any paths you'd like to explore?

@prankul88 idea -o wide is simple and makes sense to follow kubectl.

  # List all pods in ps output format with more information (such as node name).
  kubectl get pods -o wide  
  • 👍 We're adding more information (i. e. age)

  • 👎 -o wide is not only adding more information, but also changing the format (i. e. adding a header)

I think the flag should make explicit that the format will be changed and headers/ field names will be added

@msscaroso
Copy link

Maybe kind get clusters -l?

The current behavior isn't changed:

$ kind get clusters
another-kind-cluster
kind

And then with the -l (long) flag:

$ kind get clusters -l
Name                  Age
kind                  30m
capi-quickstart       15m

(Still thinking about the flag design. I know you mentioned about discussing how it is going to be actually implemented, but I'm not there yet)

@msscaroso msscaroso removed their assignment Jan 27, 2021
@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 27, 2021
@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 28, 2021
@BenTheElder BenTheElder removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 23, 2021
@kubernetes-sigs kubernetes-sigs deleted a comment from fejta-bot Jun 23, 2021
@kubernetes-sigs kubernetes-sigs deleted a comment from fejta-bot Jun 23, 2021
@BenTheElder
Copy link
Member

Sorry I personally haven't had much time to put into this and I think the same is true of the other maintainers.
I've just gotten that bot disable for this repo though, so hopefully this issue will continue to be tracked until it can get proper attention.

@MadhavJivrajani
Copy link

/remove-kind design
/kind feature
kind/design is migrated to kind/feature, see kubernetes/community#6144 for more details

@k8s-ci-robot k8s-ci-robot removed the kind/design Categorizes issue or PR as related to design. label Oct 11, 2021
@BenTheElder
Copy link
Member

I don't think there's much demand for this relative to the complexity and the portability issues this would bring so I'm going to close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

5 participants