Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support KIND_CLUSTER_NAME #1094

Closed
BenTheElder opened this issue Nov 13, 2019 · 3 comments · Fixed by #1493
Closed

support KIND_CLUSTER_NAME #1094

BenTheElder opened this issue Nov 13, 2019 · 3 comments · Fixed by #1493
Assignees
@BenTheElder
Labels
kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature.
Milestone
2020 goals

Comments

@BenTheElder
Copy link
Member

needs a little more thought but roughly see #850

moving tracking over here, the bulk of #850 (the breaking and most useful parts imho) landed for v0.6.0, this will be an interesting additional feature for v0.7.0
@BenTheElder BenTheElder added kind/feature Categorizes issue or PR as related to a new feature. kind/design Categorizes issue or PR as related to design. labels Nov 13, 2019
@BenTheElder BenTheElder added this to the v0.7.0 milestone Nov 13, 2019
@BenTheElder BenTheElder self-assigned this Nov 13, 2019
@BenTheElder BenTheElder mentioned this issue Nov 13, 2019
Closed
@prksu
Copy link

prksu commented Nov 16, 2019

@BenTheElder can i do this one?

some question. currently, we have "kind" as DefaultClusterName should we replace it with env variable? or still used it if KIND_CLUSTER_NAME env not set?

@BenTheElder
Copy link
Member Author

Hi, you can but I recommend a "good first issue" or "help wanted" for starting usually. We are not going to merge this before v0.6.0

some question. currently, we have "kind" as DefaultClusterName should we replace it with env variable? or still used it if KIND_CLUSTER_NAME env not set?

The environment variables should only be used when set and when the flag is not set. Otherwise we should maintain the default. (See #850)

This logic should be de-duplicated in an internal package (something like pkg/cmd/internal/flag).

@prksu prksu mentioned this issue Nov 17, 2019
Closed
@prksu
Copy link

prksu commented Nov 17, 2019

@BenTheElder just created a PR on #1099

please take a look 😁

@BenTheElder BenTheElder mentioned this issue Dec 24, 2019
Closed
@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 15, 2020
@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 16, 2020
@kubernetes-sigs kubernetes-sigs deleted a comment from fejta-bot Mar 16, 2020
@kubernetes-sigs kubernetes-sigs deleted a comment from fejta-bot Mar 16, 2020
@BenTheElder BenTheElder removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 16, 2020
@BenTheElder BenTheElder mentioned this issue Mar 19, 2020
Closed
@BenTheElder BenTheElder modified the milestones: v0.7.0, 2020 goals Apr 8, 2020
@amwat amwat mentioned this issue Apr 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenTheElder BenTheElder

Labels
kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
2020 goals
Development

Successfully merging a pull request may close this issue.

Support KIND_CLUSTER_NAME. amwat/kind
3 participants
@BenTheElder @k8s-ci-robot @prksu