Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support kubelet.cpuManagerPolicy in NodePools #697

Closed
olibenni opened this issue May 26, 2023 · 7 comments
Closed

Support kubelet.cpuManagerPolicy in NodePools #697

olibenni opened this issue May 26, 2023 · 7 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@olibenni
Copy link

Tell us about your request

I would like to provision some nodes with static CPU, without having a specific node template for those nodes.

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

Shipping a static CPU node with my provisioner.

Are you currently working around this issue?

I have a specific node template using userData to set the cpu manager policy to static.
As supported by aws/karpenter-provider-aws#2271

Additional Context

I'd rather not maintain multiple node templates if the only difference between them is the userData.

Attachments

No response

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@olibenni olibenni added the kind/feature Categorizes issue or PR as related to a new feature. label May 26, 2023
@njtran njtran transferred this issue from aws/karpenter-provider-aws Nov 2, 2023
@jonathan-innis
Copy link
Member

@olibenni Are you blocked on this not being in the spec.kubelet today?

@jonathan-innis jonathan-innis changed the title Support kubeletConfiguration.cpuManagerPolicy in Provisioners Support kubeletConfiguration.cpuManagerPolicy in Provisioners Nov 25, 2023
@jonathan-innis jonathan-innis changed the title Support kubeletConfiguration.cpuManagerPolicy in Provisioners Support kubelet.cpuManagerPolicy in NodePools Nov 25, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 23, 2024
@Bryce-Soghigian
Copy link
Member

/remove-lifecycle stale

@Bryce-Soghigian
Copy link
Member

Bryce-Soghigian commented Feb 23, 2024

Would be good to start discussion if we can support all the values here: https://learn.microsoft.com/en-us/azure/aks/custom-node-configuration?tabs=linux-node-pools#linux-kubelet-custom-configuration one of which is cpuManagerPolicy.

@olibenni
Copy link
Author

olibenni commented Mar 8, 2024

@jonathan-innis sorry for a super later reply.
This is not blocking me at all today. But I still believe, as @Bryce-Soghigian points out, that supporting all the kubectl values is helpful.

@jonathan-innis
Copy link
Member

But I still believe, as @Bryce-Soghigian points out, that supporting all the kubectl values is helpful

It's a good point. We combined the conversation for AWS here: aws/karpenter-provider-aws#5833. We've gotten a number of requests to add non-scheduling related fields to the Kubelet Configuration and I figure that it will be good to combine all of this conversation into one place. It's on the AWS-side because there's pretty strong sentiment that we should move the kubelet block over to the NodeClass API as part of v1

@Bryce-Soghigian
Copy link
Member

Started a thread here on the AKS side: Azure/karpenter-provider-azure#196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants