Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Log query features to kubelet config #683

Closed
rothgar opened this issue Aug 8, 2023 · 6 comments
Closed

Add Log query features to kubelet config #683

rothgar opened this issue Aug 8, 2023 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@rothgar
Copy link

rothgar commented Aug 8, 2023

Description

What problem are you trying to solve?
Configuring kubelet to enable log query feature gates.

It seems that most of the kubelet configuration settings we support are focused on resource utilization and eviction. Do we have any plans to extend that to other kubelet settings?

The kubelet settings I would like are:

  • NodeLogQuery
  • enableSystemLogHandler
  • enableSystemLogQuery

NodeLogQuery is currently an alpha feature in 1.27 which is why I wanted to start a discussion about future plans for kubelet configuration for these types of settings. I'm assuming for alpha settings they would only be exposed in user-data but GA features might be easier to manage declaratively in the CRD

How important is this feature to you?
Medium important because this can be done via user-data, but it would be cleaner to have as part of the kubelet configuration.

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@rothgar rothgar added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 8, 2023
@bwagner5
Copy link
Contributor

So far, we've mainly been adding KubeletConfiguration that affects scheduling and leaving everything else to user-data. We can reevaulate this stance though since I do agree it's cleaner in one section rather than half in the provisioner and half in user-data.

@rothgar
Copy link
Author

rothgar commented Aug 14, 2023

I never found a clean way to add KUBELET_EXTRA_ARGS to user-data. If we have a documented way or example to do that it would probably help in this situation.

@bwagner5
Copy link
Contributor

I don't have a good answer for kubelet extra args, but for kubeletConfiguration, which it looks like the params you want are, we recommend this.

apiVersion: karpenter.k8s.aws/v1alpha1
kind: AWSNodeTemplate
metadata:
  name: kubelet-config-example
spec:
  subnetSelector:
    karpenter.sh/discovery: my-cluster
  securityGroupSelector:
    karpenter.sh/discovery: my-cluster
  userData: |
    #!/bin/bash
    echo "$(jq '.kubeAPIQPS=50' /etc/kubernetes/kubelet/kubelet-config.json)" > /etc/kubernetes/kubelet/kubelet-config.json

@njtran njtran transferred this issue from aws/karpenter-provider-aws Nov 2, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 31, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 1, 2024
@jonathan-innis
Copy link
Member

Closing this one for AWS in favor of aws/karpenter-provider-aws#5833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants