Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Additional Conformance Test Flags #136

Merged
merged 14 commits into from
Jan 29, 2024

Conversation

reetasingh
Copy link
Contributor

@reetasingh reetasingh commented Jan 28, 2024

Fixes #95

verified run by passing additional flags

reeta@Reetas-MacBook-Pro hydrophone % go run main.go --extra-args="--list-conformance-tests=true,--allowed-not-ready-nodes=2"
23:12:36 INF API endpoint : https://127.0.0.1:50108
23:12:36 INF Server version : version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.0", GitCommit:"4ce5a8954017644c5420bae81d72b09b735c21f0", GitTreeState:"clean", BuildDate:"2022-05-19T15:42:59Z", GoVersion:"go1.18.1", Compiler:"gc", Platform:"linux/arm64"}
23:12:36 INF Using conformance image : 'registry.k8s.io/conformance:v1.24.0'
23:12:36 INF Using busybox image : 'registry.k8s.io/e2e-test-images/busybox:1.36.1-1'
23:12:36 INF Test framework will start '1' threads and use verbosity '4'
23:12:36 INF namespace created conformance

23:12:36 INF serviceaccount created conformance-serviceaccount

23:12:36 INF clusterrole created conformance-serviceaccount

23:12:36 INF clusterrolebinding created conformance-serviceaccount-role

23:12:36 INF pod created e2e-conformance-test

sep is " " args are "--list-conformance-tests=true --allowed-not-ready-nodes=2"split [--list-conformance-tests=true --allowed-not-ready-nodes=2]
2024/01/28 07:12:36 Running command:
Command env: []
Run from directory: 
Executable path: /usr/local/bin/ginkgo
Args (comma-delimited): /usr/local/bin/ginkgo,--focus=\[Conformance\],--skip=,--noColor=true,/usr/local/bin/e2e.test,--,--disable-log-dump,--repo-root=/kubernetes,--provider=skeleton,--report-dir=/tmp/results,--kubeconfig=,--list-conformance-tests=true,--allowed-not-ready-nodes=2
2024/01/28 07:12:36 Now listening for interrupts
- testname: Admission webhook, list mutating webhooks
  codename: '[sig-api-machinery] AdmissionWebhook [Privileged:ClusterAdmin] listing
    mutating webhooks should work [Conformance]'
  description: Create 10 mutating webhook configurations, all with a label. Attempt
    to list the webhook configurations matching the label; all the created webhook
    configurations MUST be present. Attempt to create an object; the object MUST be
    mutated. Attempt to remove the webhook configurations matching the label with
    deletecollection; all webhook configurations MUST be deleted. Attempt to create
    an object; the object MUST NOT be mutated.
  release: v1.16

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 28, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 28, 2024
@reetasingh
Copy link
Contributor Author

/retest

Copy link
Collaborator

@rjsadow rjsadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! The test is currently failing because make fmt needs to be ran.

cmd/root.go Outdated Show resolved Hide resolved
pkg/common/args_test.go Outdated Show resolved Hide resolved
pkg/common/args_test.go Show resolved Hide resolved
@reetasingh
Copy link
Contributor Author

@rjsadow fixed review comments. I am not clear on whats wrong with the boilerplate header for args_test.go. Verify job is failing

@rjsadow
Copy link
Collaborator

rjsadow commented Jan 28, 2024

Yeah, seems odd. I'll look more closely in a little bit.

pkg/common/args_test.go Outdated Show resolved Hide resolved
@rjsadow
Copy link
Collaborator

rjsadow commented Jan 28, 2024

/lgtm
/approve
/hold remove when you're ready to merge!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reetasingh, rjsadow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2024
@rakshitgondwal
Copy link
Member

rakshitgondwal commented Jan 28, 2024

/lgtm
I believe we can improve the test coverage, but this is a good start. We can cover this in another PR.

@reetasingh
Copy link
Contributor Author

/hold remove

@reetasingh
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 993028e into kubernetes-sigs:main Jan 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lack of Support for Additional Conformance Test Flags
4 participants