Migrate to csi proxy v2 alpha #1071

alexander-ding · 2022-10-31T19:54:53Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Migrates GCP Compute PD CSI Driver to use CSI Proxy v2. Besides updating the Go package code to use the new library, we also update the deployment files to run the driver as HostProcess containers. See the linked issue.

Which issue(s) this PR fixes:

Fixes #1070

Special notes for your reviewer:

This is a work in progress. We still need to update documentation to reflect the increased minimal Kubernetes version.

Does this PR introduce a user-facing change?:

Migrated Windows CSI node plugin to HostProcess containers

Action required: Ensure that the k8s version is 1.23+ and set the security policies
in the cluster to enable the HostProcess container feature only to system workloads.

k8s-ci-robot · 2022-10-31T19:55:02Z

Hi @alexander-ding. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alexander-ding · 2022-10-31T19:55:18Z

/cc @mauriciopoppe

mauriciopoppe · 2022-10-31T19:57:54Z

/ok-to-test
/test pull-gcp-compute-persistent-disk-csi-driver-e2e-win2019

There's an optional presubmit job for Windows, please look for it in the test-infra codebase

mauriciopoppe · 2022-10-31T19:58:20Z

It was not /test pull-gcp-compute-persistent-disk-csi-driver-e2e-win2019 :(

alexander-ding · 2022-10-31T20:04:47Z

/test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019

mauriciopoppe · 2022-10-31T20:09:56Z

I haven't run /test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019 in a while so it might have drifted from the CI one, I'd take that one and compare it with the presubmit

alexander-ding · 2022-10-31T21:47:41Z

/retest

mauriciopoppe

/lgtm
/assign @mattcary

mauriciopoppe · 2022-11-01T01:42:00Z

deploy/kubernetes/base/node_windows/node.yaml

+      securityContext:
+        windowsOptions:
+          hostProcess: true
+          runAsUserName: "NT AUTHORITY\\SYSTEM" # TODO: customize


Remove TODO

mauriciopoppe · 2022-11-01T01:50:15Z

Dockerfile.Windows

@@ -24,6 +24,8 @@ RUN cd /code/ && GOARCH=$(echo $TARGETPLATFORM | cut -f2 -d '/') GCE_PD_CSI_STAG

 FROM ${BASE_IMAGE}


A followup item is to use the new base image that sig-windows created in https://static.sched.com/hosted_files/kccncna2022/c6/HPC-talk.pdf

mauriciopoppe · 2022-11-01T01:51:05Z

Dockerfile.Windows

@@ -24,6 +24,8 @@ RUN cd /code/ && GOARCH=$(echo $TARGETPLATFORM | cut -f2 -d '/') GCE_PD_CSI_STAG

 FROM ${BASE_IMAGE}
 LABEL description="PD CSI driver"
+ENV PATH="${PATH};c:\\Windows\\System32\\WindowsPowerShell\\v1.0"


This might not be needed after the new base image

mauriciopoppe · 2022-11-01T01:52:56Z

The last run https://testgrid.k8s.io/provider-gcp-compute-persistent-disk-csi-driver#windows-2019-presubmit-gcp-compute-persistent-disk-csi-driver is red but here it's green, probably you can check again after removing the TODO

mauriciopoppe · 2022-11-01T16:30:37Z

One more thing, I created a few tracking issues a while ago in this repo too, I think we should use those

kubernetes-csi/csi-proxy#217 tracks the issues in this repo

mauriciopoppe

In the release note it should say something along the lines of:

Migrated Windows CSI node plugin to HostProcess containers

Action required: Ensure that the k8s version is 1.23+ and set the security policies
in the cluster to enable the HostProcess container feature only to system workloads

k8s-ci-robot · 2022-11-01T19:11:36Z

New changes are detected. LGTM label has been removed.

mauriciopoppe · 2022-11-01T19:29:25Z

/test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019

mattcary · 2022-11-01T19:35:28Z

Thanks for the PR @alexander-ding !

/approve

I'll let @mauriciopoppe give the final lgtm when all the comments are fixed.

k8s-ci-robot · 2022-11-01T19:35:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-ding, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mattcary]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2022-12-21T18:35:53Z

@alexander-ding: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-triage-robot · 2023-03-21T19:25:05Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2023-04-20T19:40:37Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

mauriciopoppe · 2023-04-30T04:16:51Z

/remove-lifecycle rotten

k8s-triage-robot · 2024-01-19T00:57:01Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-02-18T00:59:11Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2024-03-19T01:45:58Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2024-03-19T01:46:02Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mauriciopoppe · 2024-04-26T17:25:59Z

/reopen
/remove-lifecycle rotten

k8s-ci-robot · 2024-04-26T17:26:03Z

@mauriciopoppe: Reopened this PR.

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-triage-robot · 2024-07-25T17:48:34Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-08-24T18:18:33Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2024-09-23T19:09:22Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2024-09-23T19:09:27Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot requested review from mattcary and saikat-royc October 31, 2022 19:55

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 31, 2022

k8s-ci-robot requested a review from mauriciopoppe October 31, 2022 19:55

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 31, 2022

mauriciopoppe reviewed Nov 1, 2022

View reviewed changes

k8s-ci-robot assigned mattcary and mauriciopoppe Nov 1, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2022

mauriciopoppe reviewed Nov 1, 2022

View reviewed changes

alexander-ding force-pushed the enh/windows-hostprocess branch from 53baf47 to e6b3ba1 Compare November 1, 2022 19:11

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2022

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 21, 2022

msau42 mentioned this pull request Mar 10, 2023

Serial mkfs #1169

Merged

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 21, 2023

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 20, 2023

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Apr 30, 2023

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 18, 2024

k8s-ci-robot closed this Mar 19, 2024

k8s-ci-robot reopened this Apr 26, 2024

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Apr 26, 2024

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 25, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 24, 2024

k8s-ci-robot closed this Sep 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to csi proxy v2 alpha #1071

Migrate to csi proxy v2 alpha #1071

alexander-ding commented Oct 31, 2022 •

edited

Loading

k8s-ci-robot commented Oct 31, 2022

alexander-ding commented Oct 31, 2022

mauriciopoppe commented Oct 31, 2022

mauriciopoppe commented Oct 31, 2022

alexander-ding commented Oct 31, 2022

mauriciopoppe commented Oct 31, 2022

alexander-ding commented Oct 31, 2022

mauriciopoppe left a comment

mauriciopoppe Nov 1, 2022

mauriciopoppe Nov 1, 2022

mauriciopoppe Nov 1, 2022

mauriciopoppe commented Nov 1, 2022

mauriciopoppe commented Nov 1, 2022

mauriciopoppe left a comment

k8s-ci-robot commented Nov 1, 2022

mauriciopoppe commented Nov 1, 2022

mattcary commented Nov 1, 2022

k8s-ci-robot commented Nov 1, 2022

k8s-ci-robot commented Dec 21, 2022

k8s-triage-robot commented Mar 21, 2023

k8s-triage-robot commented Apr 20, 2023

mauriciopoppe commented Apr 30, 2023

k8s-triage-robot commented Jan 19, 2024

k8s-triage-robot commented Feb 18, 2024

k8s-triage-robot commented Mar 19, 2024

k8s-ci-robot commented Mar 19, 2024

mauriciopoppe commented Apr 26, 2024

k8s-ci-robot commented Apr 26, 2024

k8s-triage-robot commented Jul 25, 2024

k8s-triage-robot commented Aug 24, 2024

k8s-triage-robot commented Sep 23, 2024

k8s-ci-robot commented Sep 23, 2024

		@@ -24,6 +24,8 @@ RUN cd /code/ && GOARCH=$(echo $TARGETPLATFORM \| cut -f2 -d '/') GCE_PD_CSI_STAG

		FROM ${BASE_IMAGE}

Migrate to csi proxy v2 alpha #1071

Migrate to csi proxy v2 alpha #1071

Conversation

alexander-ding commented Oct 31, 2022 • edited Loading

k8s-ci-robot commented Oct 31, 2022

alexander-ding commented Oct 31, 2022

mauriciopoppe commented Oct 31, 2022

mauriciopoppe commented Oct 31, 2022

alexander-ding commented Oct 31, 2022

mauriciopoppe commented Oct 31, 2022

alexander-ding commented Oct 31, 2022

mauriciopoppe left a comment

Choose a reason for hiding this comment

mauriciopoppe Nov 1, 2022

Choose a reason for hiding this comment

mauriciopoppe Nov 1, 2022

Choose a reason for hiding this comment

mauriciopoppe Nov 1, 2022

Choose a reason for hiding this comment

mauriciopoppe commented Nov 1, 2022

mauriciopoppe commented Nov 1, 2022

mauriciopoppe left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Nov 1, 2022

mauriciopoppe commented Nov 1, 2022

mattcary commented Nov 1, 2022

k8s-ci-robot commented Nov 1, 2022

k8s-ci-robot commented Dec 21, 2022

k8s-triage-robot commented Mar 21, 2023

k8s-triage-robot commented Apr 20, 2023

mauriciopoppe commented Apr 30, 2023

k8s-triage-robot commented Jan 19, 2024

k8s-triage-robot commented Feb 18, 2024

k8s-triage-robot commented Mar 19, 2024

k8s-ci-robot commented Mar 19, 2024

mauriciopoppe commented Apr 26, 2024

k8s-ci-robot commented Apr 26, 2024

k8s-triage-robot commented Jul 25, 2024

k8s-triage-robot commented Aug 24, 2024

k8s-triage-robot commented Sep 23, 2024

k8s-ci-robot commented Sep 23, 2024

alexander-ding commented Oct 31, 2022 •

edited

Loading