Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate HTTP filter discriminated union consistency. #942

Closed
jpeach opened this issue Nov 18, 2021 · 1 comment · Fixed by #946
Closed

Validate HTTP filter discriminated union consistency. #942

jpeach opened this issue Nov 18, 2021 · 1 comment · Fixed by #946
Assignees
@crmejia
Labels
area/webhook good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jpeach
Copy link
Contributor

jpeach commented Nov 18, 2021

HTTPRouteFilter is a discriminated union where the Type field is the discriminator. The admission controller should validate that the only the matching field is present.
@jpeach jpeach added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 18, 2021
@hbagdi hbagdi added area/webhook good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Nov 19, 2021
@crmejia
Copy link
Contributor

crmejia commented Nov 19, 2021

/assign
I'll take a swing a this!

@crmejia crmejia mentioned this issue Nov 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crmejia crmejia

Labels
area/webhook good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validating HTTPRouteFilter type consistency crmejia/gateway-api
3 participants
@jpeach @crmejia @hbagdi