-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need v1alpha1 equivalent examples for v1alpha2 #666
Comments
One solution that I can think of is to have a v1alpha2 directory inside the existing examples directory, copy over the existing examples, change their API versions and go from there. |
I made some assumptions for this in #657 where I created a new v1alpha2 directory in /examples. |
It's possible that we should copy all examples over to that in one go, but instead I just copied them over as they changed. |
Should we copy these over first in a PR and then change them as we go forward? I can send a PR if that works. |
I don't have a strong opinion here, but would lean towards copying examples over as they're needed. One advantage of this approach is that we won't end up with stale examples that we never reference or use. It provides a natural way to get rid of examples from v1alpha1 that are no longer useful. |
I tend to agree with @robscott here, but maybe we need to add a release checklist note to review the examples and bring forward any that are still relevant? |
Yep, that's a great idea |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/lifecycle frozen @robscott we should probably look at this one soon. |
@youngnick Added to v1alpha2 milestone. Now that API is mostly finalized, it probably makes sense to split examples into v1alpha1 and v1alpha2 directories, and ensure that we have v1alpha2 examples to correspond with all v1alpha1 examples. |
Agreed. My current plan is to do exactly that - I'll move the currently-unversioned examples into a Additionally, I think that having the examples be in a directory each will greatly help using them in the guides, since we can include the example YAML in the guide when it's rendered. |
This work is complete, the examples are now split between versions, the only remaining work is to update guides and examples, which is already tracked in #783 . |
What happened:
There is not way to write examples for v1alpha2 resources.
What you expected to happen:
There should be a way to write v1alpha2 examples.
The text was updated successfully, but these errors were encountered: