Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need v1alpha1 equivalent examples for v1alpha2 #666

Closed
hbagdi opened this issue May 13, 2021 · 12 comments
Closed

Need v1alpha1 equivalent examples for v1alpha2 #666

hbagdi opened this issue May 13, 2021 · 12 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone

Comments

@hbagdi
Copy link
Contributor

hbagdi commented May 13, 2021

What happened:

There is not way to write examples for v1alpha2 resources.

What you expected to happen:

There should be a way to write v1alpha2 examples.

@hbagdi hbagdi added the kind/bug Categorizes issue or PR as related to a bug. label May 13, 2021
@hbagdi hbagdi changed the title Repo structure for generating v1alpha2 CRDs and examples Repo structure for v1alpha2 examples May 13, 2021
@hbagdi
Copy link
Contributor Author

hbagdi commented May 13, 2021

One solution that I can think of is to have a v1alpha2 directory inside the existing examples directory, copy over the existing examples, change their API versions and go from there.
We can't change the existing examples because they are referenced in docs site.

@robscott
Copy link
Member

I made some assumptions for this in #657 where I created a new v1alpha2 directory in /examples.

@robscott
Copy link
Member

It's possible that we should copy all examples over to that in one go, but instead I just copied them over as they changed.

@hbagdi
Copy link
Contributor Author

hbagdi commented May 13, 2021

Should we copy these over first in a PR and then change them as we go forward? I can send a PR if that works.
It might have happen that some never change and we might miss some of those examples, which will then later break our docs site once it switches to v1alpha2.

@robscott
Copy link
Member

I don't have a strong opinion here, but would lean towards copying examples over as they're needed. One advantage of this approach is that we won't end up with stale examples that we never reference or use. It provides a natural way to get rid of examples from v1alpha1 that are no longer useful.

@youngnick
Copy link
Contributor

I tend to agree with @robscott here, but maybe we need to add a release checklist note to review the examples and bring forward any that are still relevant?

@robscott
Copy link
Member

maybe we need to add a release checklist note to review the examples and bring forward any that are still relevant?

Yep, that's a great idea

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 15, 2021
@youngnick
Copy link
Contributor

/lifecycle frozen

@robscott we should probably look at this one soon.

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 16, 2021
@robscott robscott added this to the v1alpha2 milestone Aug 16, 2021
@robscott
Copy link
Member

@youngnick Added to v1alpha2 milestone. Now that API is mostly finalized, it probably makes sense to split examples into v1alpha1 and v1alpha2 directories, and ensure that we have v1alpha2 examples to correspond with all v1alpha1 examples.

@youngnick
Copy link
Contributor

Agreed. My current plan is to do exactly that - I'll move the currently-unversioned examples into a v1alpha1 directory and update the v1alpha1 guides, then we can do the v1alpha2 stuff as we get the guides and examples updated.

Additionally, I think that having the examples be in a directory each will greatly help using them in the guides, since we can include the example YAML in the guide when it's rendered.

@robscott robscott changed the title Repo structure for v1alpha2 examples Need v1alpha1 equivalent examples for v1alpha2 Aug 23, 2021
@youngnick
Copy link
Contributor

This work is complete, the examples are now split between versions, the only remaining work is to update guides and examples, which is already tracked in #783 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

5 participants