Job post-gateway-api-push-images started failing on 09-11

[aojea]

What happened:

https://testgrid.k8s.io/sig-network-gateway-api#post-gateway-api-push-images

hack/build-and-push.sh
unknown flag: --build-arg
See 'docker --help'.
Usage:  docker [OPTIONS] COMMAND

There were several changes in this area 7a13241

[aojea]

@wilsonwu you restored those flags recently b48859c

[aojea]

/cc @robscott @shaneutt

[wilsonwu]

@wilsonwu you restored those flags recently b48859c

#1542 try to fix in this PR.

The latest problem:

Status: Downloaded newer image for gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20211118-2f2d816b90
gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20211118-2f2d816b90
hack/build-and-push.sh
unknown shorthand flag: 'f' in -f
See 'docker --help'.
Usage:  docker [OPTIONS] COMMAND

[aojea]

wow, that was fast , thanks

/assign @wilsonwu

I'll assign to to you then

[wilsonwu]

After #1542 PR merged, still has problem, need help @shaneutt

gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20211118-2f2d816b90
hack/build-and-push.sh
unknown shorthand flag: 't' in -t
See 'docker --help'.
Usage:  docker [OPTIONS] COMMAND
A self-sufficient runtime for containers

I tried this docker container can support buildx command.

Timeline of this feature:
#1462 #1522 #1542

[Xunzhuo]

I can help on this if you are willing to : ) @wilsonwu

[wilsonwu]

I can help on this if you are willing to : ) @wilsonwu

Yes please, I checked that the gcb-docker-gcloud image could support buildx: https://github.com/kubernetes/test-infra/tree/master/images/gcb-docker-gcloud.

And it works in my local env, please help to fix it.

[wilsonwu]

Can you share how you test this image locally @wilsonwu ?

I just tested the make command and script in my local env(not in container), and also checked the job image could support docker buildx command.

BTW: I am tring to use dind to test the script but not success now, still tring...

[Xunzhuo]

Yep, I tested the gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20211118-2f2d816b90, and yes, docker buildx is supported.

#1549 added verify and log for docker buildx, I think this can provide more context on the docker buildx issue.

[Xunzhuo]

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-gateway-api-push-images/1593583940357066752
Looks like we can not find docker buildx in our CI workflows.

[Xunzhuo]

This is weird, some options I think:

1. Try to upgrade the gcb-docker-gcloud image to the latest.
2. Try to change the build image.

I will take some time later this day to look into this issue.

[shaneutt]

Sounds good, thanks for the help @Xunzhuo!

[wilsonwu]

I suggest to change a build image.

And I am looking for a good build image from popular repos.

[wilsonwu]

I suggest to change a build image.

And I am looking for a good build image from popular repos.

I found the istio build tools image is good as build image: gcr.io/istio-testing/build-tools

[robscott]

#1552 didn't work. Looks like we should try to use something like what ingress-nginx is doing: https://github.com/kubernetes/ingress-nginx/blob/main/hack/init-buildx.sh.

[Xunzhuo]

Nope, something is different now, at least, docker supports docker buildx now.

[Xunzhuo]

We passed image verify now, before #1552:

For now, I think we just need some setups for muli-arch buildx context : )

cc @robscott @wilsonwu

[wilsonwu]

Good job, I added: docker buildx create --use, I think it can be solved.