Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook: validate TLS config must be set when protocol is HTTPS/TLS #1467

Closed
gyohuangxin opened this issue Oct 19, 2022 · 1 comment · Fixed by #1470
Closed

Webhook: validate TLS config must be set when protocol is HTTPS/TLS #1467

gyohuangxin opened this issue Oct 19, 2022 · 1 comment · Fixed by #1470
Assignees
@gyohuangxin
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v0.6.0

Comments

@gyohuangxin
Copy link
Member

What would you like to be added:

As discussed in #1460 (comment), it's worth adding a validation to validate TLS config must be set when protocol is HTTPS/TLS

Why this is needed:
Because we need to validate TLS config must be set when protocol is HTTPS/TLS
@gyohuangxin gyohuangxin added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 19, 2022
@gyohuangxin
Copy link
Member Author

/assign

@shaneutt shaneutt added this to the v0.7.0 milestone Oct 20, 2022
@gyohuangxin gyohuangxin mentioned this issue Oct 20, 2022
Merged
@shaneutt shaneutt modified the milestones: v0.7.0, v0.6.0 Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gyohuangxin gyohuangxin

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging a pull request may close this issue.

Webhook: validate TLS config must be set when protocol is HTTPS or TLS. gyohuangxin/gateway-api
2 participants
@shaneutt @gyohuangxin