feat: enable Azure subscription ID override #4186

pascalgn · 2024-01-16T20:35:56Z

Description

There already is a --azure-subscription-id flag, but it currently doesn't do anything. This PR adds the few missing lines that make it work, to be able to actually override the Azure subscription.

Checklist

Unit tests updated
End user documentation updated

k8s-ci-robot · 2024-01-16T20:36:06Z

Hi @pascalgn. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pascalgn · 2024-01-16T21:00:08Z

pkg/apis/externaldns/types.go

-	app.Flag("azure-resource-group", "When using the Azure provider, override the Azure resource group to use (required when --provider=azure-private-dns)").Default(defaultConfig.AzureResourceGroup).StringVar(&cfg.AzureResourceGroup)
-	app.Flag("azure-subscription-id", "When using the Azure provider, specify the Azure configuration file (required when --provider=azure-private-dns)").Default(defaultConfig.AzureSubscriptionID).StringVar(&cfg.AzureSubscriptionID)
+	app.Flag("azure-resource-group", "When using the Azure provider, override the Azure resource group to use (optional)").Default(defaultConfig.AzureResourceGroup).StringVar(&cfg.AzureResourceGroup)
+	app.Flag("azure-subscription-id", "When using the Azure provider, override the Azure subscription to use (optional)").Default(defaultConfig.AzureSubscriptionID).StringVar(&cfg.AzureSubscriptionID)


Both flags are actually not required, because the value are taken from the config file by default, so I changed the help text here

pascalgn · 2024-01-16T21:01:11Z

provider/azure/config_test.go

+	}
+	assert.Equal(t, cfg.SubscriptionID, "subscription-override")
+	assert.Equal(t, cfg.ResourceGroup, "rg-override")
+}


Not sure if this test is useful/wanted, can also be removed

It can help to ensures that the override still work when someone else makes a PR

mloiseleur · 2024-01-17T08:24:15Z

/ok-to-test

mloiseleur · 2024-01-17T08:31:34Z

/lgtm

szuecs · 2024-02-07T15:31:09Z

/approve

k8s-ci-robot · 2024-02-07T15:31:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [szuecs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pascalgn · 2024-02-07T19:15:19Z

I created #4240 to consolidate discussions of TestCoreDNSApplyChanges test failure

pascalgn · 2024-02-15T09:18:45Z

@mloiseleur I rebased, could you maybe have a look again when you have time? 🙏

mloiseleur · 2024-02-15T13:32:33Z

/lgtm

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 16, 2024

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 16, 2024

k8s-ci-robot requested review from johngmyers and mloiseleur January 16, 2024 20:36

pascalgn force-pushed the azure-subscription-id-override branch from 8c6b720 to 6f28a02 Compare January 16, 2024 20:54

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 16, 2024

pascalgn force-pushed the azure-subscription-id-override branch from 6f28a02 to 98f014e Compare January 16, 2024 20:56

pascalgn marked this pull request as ready for review January 16, 2024 20:56

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2024

pascalgn commented Jan 16, 2024

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 17, 2024

k8s-ci-robot assigned mloiseleur Jan 17, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2024

feat: enable Azure subscription ID override

be7cac2

pascalgn force-pushed the azure-subscription-id-override branch from 98f014e to be7cac2 Compare February 9, 2024 11:18

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2024

k8s-ci-robot merged commit 52460ba into kubernetes-sigs:master Feb 15, 2024
12 checks passed

tinfoild bot mentioned this pull request Sep 5, 2024

feat(github/external-dns-git): update v0.14.0 ➼ v0.15.0 JJGadgets/Biohazard#1051

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: enable Azure subscription ID override #4186

feat: enable Azure subscription ID override #4186

pascalgn commented Jan 16, 2024 •

edited

Loading

k8s-ci-robot commented Jan 16, 2024

pascalgn Jan 16, 2024 •

edited

Loading

pascalgn Jan 16, 2024

mloiseleur Jan 17, 2024

mloiseleur commented Jan 17, 2024

mloiseleur commented Jan 17, 2024

szuecs commented Feb 7, 2024

k8s-ci-robot commented Feb 7, 2024

pascalgn commented Feb 7, 2024

pascalgn commented Feb 15, 2024

mloiseleur commented Feb 15, 2024

feat: enable Azure subscription ID override #4186

feat: enable Azure subscription ID override #4186

Conversation

pascalgn commented Jan 16, 2024 • edited Loading

k8s-ci-robot commented Jan 16, 2024

pascalgn Jan 16, 2024 • edited Loading

Choose a reason for hiding this comment

pascalgn Jan 16, 2024

Choose a reason for hiding this comment

mloiseleur Jan 17, 2024

Choose a reason for hiding this comment

mloiseleur commented Jan 17, 2024

mloiseleur commented Jan 17, 2024

szuecs commented Feb 7, 2024

k8s-ci-robot commented Feb 7, 2024

pascalgn commented Feb 7, 2024

pascalgn commented Feb 15, 2024

mloiseleur commented Feb 15, 2024

pascalgn commented Jan 16, 2024 •

edited

Loading

pascalgn Jan 16, 2024 •

edited

Loading