Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerDNS --domain-filter not able to match just 1 sub-zone #3822

Closed
mhanc opened this issue Jul 27, 2023 · 3 comments
Closed

PowerDNS --domain-filter not able to match just 1 sub-zone #3822

mhanc opened this issue Jul 27, 2023 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mhanc
Copy link

mhanc commented Jul 27, 2023

What happened:
After the MatchParent function was added to PowerDNS provider in #2040, --domain-filter no longer produces results consistently with other providers. In case multiple sub-zones exist, it is not possible to select just ONE sub-zone by using --domain-filter or any other filter combinations. In case different API keys are set for zones, the setup always results in errors and fails to update DNS.

What you expected to happen:
Using --domain-filter sub1.example.com should just match the exact zone (no matching of parent zones like example.com), same as all other providers.

How to reproduce it (as minimally and precisely as possible):
Create PowerDNS zones:

  • example.com
  • sub1.example.com
  • sub2.example.com

Try to match just sub1.example.com.

Options:

  1. Use --domain-filter sub1.example.com - matches sub1.example.com AND example.com
  2. Use --domain-filter .sub1.example.com - matches 0 zones
  3. Use --domain-filter .example.com - matches sub1.example.com AND sub2.example.com

We would expect option 1 to work for this scenario (as it worked before adding the MatchParent function), as option 2 and 3 are working correctly, but cannot be used for this scenario.

Anything else we need to know?:
MatchParent functionality is not needed, as same results can be achieved by using --domain-filter multiple times.
No other providers use MatchFilter function, so behavior is inconsistent and unexpected.

Environment:

  • External-DNS version (use external-dns --version): v0.13.5
  • DNS provider: pdns
  • Others: different PowerDNS API keys for each zone
@mhanc mhanc added the kind/bug Categorizes issue or PR as related to a bug. label Jul 27, 2023
@joaocc
Copy link

joaocc commented Sep 27, 2023

Isn't this the same as #3948, thus not exclusively related to PDNS?

@mhanc
Copy link
Author

mhanc commented Sep 27, 2023

Isn't this the same as #3948, thus not exclusively related to PDNS?

I believe #3948 is a different issue of selecting just records (in zones), as compared to this issue, which was related to zones selection only (so basically "one level up").

@mhanc
Copy link
Author

mhanc commented Sep 27, 2023

Closing this issue as resolved, as I can confirm that this issue has been resolved by #3869 in v0.13.6 release. Thank you @matusf and all involved

@mhanc mhanc closed this as completed Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants