Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update helm test #229

Merged
merged 1 commit into from
Apr 1, 2023
Merged

update helm test #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func TestMain(m *testing.M) {
testenv.Finish(
envfuncs.DeleteNamespace(namespace),
)

// launch package tests
os.Exit(testenv.Run(m))
}
Expand Down Expand Up @@ -93,19 +93,22 @@ func TestKubernetes(t *testing.T) {
}
return ctx
}).Feature()

// test feature
testenv.Test(t, f1, f2)
}
```

#### Running the test

Use the Go testing tooling to run the tests in the package as shown below. The following would run all tests except those with label `type=ns-count`:

```
go test ./package -args --skip-labels="type=ns-count"
```

## Examples

See the [./examples](./examples) directory for additional examples showing how to use the framework.

## Community, discussion, contribution, and support
Expand Down
2 changes: 1 addition & 1 deletion examples/third_party_integration/helm/helm_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ func TestHelmChartRepoWorkflow(t *testing.T) {
Assess("Deployment is running successfully", func(ctx context.Context, t *testing.T, config *envconf.Config) context.Context {
deployment := &appsv1.Deployment{
ObjectMeta: v1.ObjectMeta{
Name: "nginx-nginx-ingress",
Name: "nginx-nginx-ingress-controller",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vladimirvivien should we have a dedicated chart pushed to the helm registry that is just meant for our test and use that instead in order to avoid failures like this one for example in the future ?

cc @cpanato

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, i can do that if you all want

Namespace: namespace,
},
Spec: appsv1.DeploymentSpec{},
Expand Down