Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crictl-exec: arg-parsing bug #335

Closed
vrothberg opened this issue Jul 4, 2018 · 3 comments · Fixed by #372
Closed

crictl-exec: arg-parsing bug #335

vrothberg opened this issue Jul 4, 2018 · 3 comments · Fixed by #372

Comments

@vrothberg
Copy link
Contributor

urfave/cli has a bug in how short-options are parsed. The problem is that the parser does not only transform the program's options (e.g., -abc -> -a -b -c) but also undefined ones and even arguments (see a description here containers/podman#714). For Podman, we are currently vendoring a patched version from github.com/vrothberg/cli (see containers/podman#1046). Feel free to vendor that as well if you want the bug fixed. urfave/cli seems to be orphaned at the moment, but once it's back in maintenance we revendor it.
@feiskyer
Copy link
Member

feiskyer commented Jul 5, 2018

@vrothberg thanks for reporting the bug. Is there any issues or PRs on urfave/cli for tracking the issue?

@vrothberg
Copy link
Contributor Author

@feiskyer Sorry, I entirely missed posting the PR for urfave/cli as well: urfave/cli#758

@feiskyer
Copy link
Member

feiskyer commented Jul 5, 2018

@vrothberg thanks

@vrothberg vrothberg mentioned this issue Aug 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vendor latest github.com/urfave/cli
2 participants
@feiskyer @vrothberg