Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No help topic for 'restore' #1376

Closed
HFourier opened this issue Mar 11, 2024 · 10 comments
Closed

No help topic for 'restore' #1376

HFourier opened this issue Mar 11, 2024 · 10 comments
Labels
kind/documentation Categorizes issue or PR as related to documentation. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@HFourier
Copy link

When I want to restore xxx.tar, a checkpoint file that created by k8s, by using command "crictl restore --import=". I was told No help topic for 'restore'. I want to know how can I restore checkpoint by crictl, this is so important for us.

@HFourier HFourier added kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Mar 11, 2024
@saschagrunert
Copy link
Member

Hey @HFourier, thank you for the report. Do you plan to contribute this documentation enhancement?

@saschagrunert saschagrunert added kind/documentation Categorizes issue or PR as related to documentation. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Mar 11, 2024
@HFourier
Copy link
Author

Hey @HFourier, thank you for the report. Do you plan to contribute this documentation enhancement?

I still beginner and I don't think I can help to enhance this documentation. In addition, I confuse that I can see "crictl restore --import=" is somewhere, but still less information about this. I want to know how can I use this command?

@saschagrunert
Copy link
Member

Ah the command restore does not even exist @HFourier.

@HFourier
Copy link
Author

HFourier commented Mar 11, 2024

Ah the command restore does not even exist @HFourier.

This is wired, I see it in YouTube [https://www.youtube.com/watch?v=0RUDoTi-Lw4](Kubernetes and Checkpoint Restore - Adrian Reber, Red Hat) at timeline16:58.

@saschagrunert
Copy link
Member

I assume during that time we discussed how the subcommand should look like. You're looking for crictl checkpoint, right?

cc @adrianreber

@adrianreber
Copy link
Contributor

Exactly. That changed a couple of times. Sometimes I was using PRs in my demos that were not merged.

If you look at https://kubernetes.io/blog/2022/12/05/forensic-container-checkpointing-alpha/ you can see two approaches how to restore checkpoints.

@HFourier
Copy link
Author

Exactly. That changed a couple of times. Sometimes I was using PRs in my demos that were not merged.

If you look at https://kubernetes.io/blog/2022/12/05/forensic-container-checkpointing-alpha/ you can see two approaches how to restore checkpoints.

OK, That would make sense. Thanks for reply!

@HFourier
Copy link
Author

Exactly. That changed a couple of times. Sometimes I was using PRs in my demos that were not merged.

If you look at https://kubernetes.io/blog/2022/12/05/forensic-container-checkpointing-alpha/ you can see two approaches how to restore checkpoints.

May I have another question? I have followed this url . Unfortunately , I meet some trouble. I try restore the pod from image build by buildah , but it only can succeed in local machine. When I save checkpoint in machine A and transfer the .tar file to machine B, then try to build images and restore pod in machine B. It failed. And we try to build the image in machine A and push it to docker.io, then restore pod by pulling images at machine B , it has the same problem. By kubectl describe pod , we can get the following information :
Error: failed to restore container migration: container restore failed: time="2024-03-04T09:23:54+08:00" level=error msg="criu failed: type RESTORE errno 0 log file: /run/containers/storage/overlay-containers/migration/userdata/restore.log"
We try to find the restore.log, but we can't get this path. When we cd into /run/containers/storage/overlay-containers, we can only see some folders such as "483162fff3a8ba5c116bec0c5677118202237326543ff4d661f4c0b1d6866f2f"

@adrianreber
Copy link
Contributor

@HFourier Adding comments to tickets which are already closed have a high chance to being missed. A couple of days there was a very similar question: checkpoint-restore/criu#2366

Take a look at that. Hope that helps.

@HFourier
Copy link
Author

@HFourier Adding comments to tickets which are already closed have a high chance to being missed. A couple of days there was a very similar question: checkpoint-restore/criu#2366

Take a look at that. Hope that helps.

Thanks, I will try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

No branches or pull requests

3 participants