Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore tests for docker runtime #1162

Closed
afbjorklund opened this issue May 5, 2023 · 2 comments
Closed

Restore tests for docker runtime #1162

afbjorklund opened this issue May 5, 2023 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@afbjorklund
Copy link
Contributor

afbjorklund commented May 5, 2023

What would you like to be added:

Need to run tests for docker, similar to cri-o.

Why is this needed:

The tests were removed because of "dockershim":

But no tests were added for the actual "cri-dockerd".


Note: It wasn't actually using dockershim for 1.24 and 1.25 either, since it had been removed from the codebase.

It just renamed the remote socket endpoint, instead of removing dockershim from cri-tools (as per Issue #870).

commit 175fbd1

@afbjorklund afbjorklund added kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. labels May 5, 2023
@afbjorklund afbjorklund changed the title Restore tests for docker Restore tests for docker runtime May 5, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2024
@afbjorklund
Copy link
Contributor Author

Not supported, needs to be tested downstream (in cri-dockerd).

@afbjorklund afbjorklund closed this as not planned Won't fix, can't repro, duplicate, stale Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants