🌱 Bump kubebuilder tools to v0.4.2 #9665
Conversation
Signed-off-by: Stefan Büringer [email protected]
k8s-ci-robot
added
cncf-cla: yes
|
/assign @killianmuldoon @fabriziopandini @chrischdi cc @kubernetes-sigs/cluster-api-release-team |
|
I think we need to merge kubernetes-sigs/kubebuilder-release-tools#58 before taking this in? cc @mjlshen |
|
/area release |
k8s-ci-robot
added
area/release
There was a problem hiding this comment.
Release v0.4.2 is still using the outdated image in its action. The current plan was to bump the versions in the kubebuilder-tools repo and then use the sha of the commit for this action so we get the correct image version.
I'm not sure when we'll get a future release of kubebuilder-tools but we should be sure to track it so we can go back to a tagged version of this action.
Yeah, probably not too soon based on the slack conversations @vincepri was also suggesting to you use sha of the commit in the meantime |
|
Fine IMO to merge this as is, but it won't unblock us. Let's merge this and wait for the updates in kubebuilder and do a follow up bump. /cc @mjlshen /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 2157673f0b0f5b9fcbf73c9283045e14d889bdec
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Do we know if the action works after the last fix? If we don't know, let's bump to the sha of the right commit to test it. We shouldn't trial-and-error going forward with kubebuilder-release-tools releases |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #