🌱 api: deprecate FailureMessage and FailureReason #11317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
59 tasks
chrischdi
force-pushed
the
pr-deprecate-failure-message-reason
branch
from
9331dcc
to
124f481
Compare
chrischdi
changed the title
sbueringer
reviewed
Oct 22, 2024
There was a problem hiding this comment.
One nit.
I've added an additional sub-task in the proposal for the other fields. But they are more complex and might require more discussion. So I think it makes sense to only deprecate failureReason & failureMessage in this PR and handle the other fields in follow-up PR(s)
chrischdi
force-pushed
the
pr-deprecate-failure-message-reason
branch
from
124f481
to
9a7d894
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 8147135ba36b206a859c9752f06702653e778c06
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
41 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Deprecates
.status.failureMessageand.status.failureReasonas proposed in docs/proposals/20240916-improve-status-in-CAPI-resources.md.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #11105
/area api