Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAPD load balancer crashes on startup #8257

Closed
killianmuldoon opened this issue Mar 9, 2023 · 7 comments · Fixed by #8469
Closed

CAPD load balancer crashes on startup #8257

killianmuldoon opened this issue Mar 9, 2023 · 7 comments · Fixed by #8469
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@killianmuldoon
Copy link
Contributor

CAPD's load balancer is known to crash by causing a resource leak on some systems - notably Fedora. This issue is caused by the initial configuration of the haproxy container used by CAPD.

This issue has been partially fixed in #8246 which updates the config to one that will not crash when used with CAPD - i.e. setting maxconn. This change has also been made in Kind.

The load balancer will still cause a resource leak with its initial configuration, however. The fix for this is either to update to the latest kindest/haproxy once one an image with the correct config is published, or to an alternative haproxy image.

Note: The upstream haproxytect/haproxy-alpine has sufficient config to avoid the resource leakage (thanks @richardcase!)

See also: #7344 (comment)

/assign
/area provider/docker
/kind bug

@k8s-ci-robot k8s-ci-robot added area/provider/docker kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 9, 2023
@fabriziopandini
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 9, 2023
@sbueringer
Copy link
Member

Given how long we lived with this issue, I would prefer waiting for the next kindest/haproxy image.

I"m not sure when it will be released, but we could ask.

@killianmuldoon
Copy link
Contributor Author

Given how long we lived with this issue, I would prefer waiting for the next kindest/haproxy image.

Agreed - there's no rush on this. Just wanted to capture the info from the closed PRs and track the image bump somewhere.

@sbueringer
Copy link
Member

Yup. Just saw the two options in the issue description, which is why I wrote which one I would prefer 😃

@richardcase
Copy link
Member

@sbueringer @killianmuldoon - i'm curious why there is a preference to use the kindest image and not an upstream image?

@killianmuldoon
Copy link
Contributor Author

From my PoV - CAPD is tightly coupled to kind, so there's no real separation from changing to an upstream image.

Otherwise this is a part of the code that's worked well for a long time without changes. I don't see any real upside to making the change to a new image, so I default to not changing it. But really I don't have very strong opinions here.

@richardcase
Copy link
Member

Thats good to know, thanks for explaining @killianmuldoon 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants