Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EqualObject Matcher ignores additional fields #5563

Closed
killianmuldoon opened this issue Nov 2, 2021 · 1 comment · Fixed by #5565
Closed

EqualObject Matcher ignores additional fields #5563

killianmuldoon opened this issue Nov 2, 2021 · 1 comment · Fixed by #5565
Labels
area/testing Issues or PRs related to testing kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@killianmuldoon
Copy link
Contributor

Expected internal/matchers.EqualObject to return false when the compared object has more fields than the original object. Currently if the original object has more fields than the actual the objects are returned as equal.

This is unexpected behaviour for those using the EqualObject matcher in tests.

Unit tests will be added to the matcher to ensure it's functioning as expected.

/kind bug
/area testing

/cc @sbueringer

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/testing Issues or PRs related to testing labels Nov 2, 2021
@vincepri
Copy link
Member

vincepri commented Nov 2, 2021

/milestone v1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants